- Issue created by @dydave
- Status changed to Needs review
6 months ago 10:11pm 21 May 2024 - π«π·France dydave
Quick follow-up on this issue:
A few additional commits were added to the current merge request MR!54 with a few comments, see above at #2.
But mostly, at this point:
Last build on MR!54: https://git.drupalcode.org/issue/field_group-3448470/-/pipelines/178635- The ESLINT job now seems to be passing β
ESLINT job: https://git.drupalcode.org/issue/field_group-3448470/-/jobs/1651323
- The PHPUnit Tests are passing as well π’ \o/
PHPUnit job: https://git.drupalcode.org/issue/field_group-3448470/-/jobs/1651325
Changes to file
MigrateUiFieldGroupTest.php
from merge request MR!49 (see π Automated Drupal 11 compatibility fixes for field_group - Fixed PHPUnit on GitlabCI RTBC ) had to be ported to this MR for the phpunit tests to complete, see:
https://git.drupalcode.org/project/field_group/-/merge_requests/49/diffs...
So changes to this file could probably be reverted once the phpunit tests are fixed in the main development branch (8.x-3.x).
We would greatly appreciate if a maintainer or someone with write permission could take a look at ticket's merge request MR!54 and let us know if there would be any more work needed.
Feel free to let us know if you have any questions or concerns on merge request MR!54 or any aspect of this ticket in general, we would surely be glad to help.
Thanks in advance for your feedback and reviews. - The ESLINT job now seems to be passing β
- π§πͺBelgium nils.destoop
nils.destoop β made their first commit to this issueβs fork.
-
nils.destoop β
committed 2143656f on 8.x-3.x authored by
DYdave β
Issue #3448470 by DYdave, nils.destoop: GitlabCI: Fix ESLINT validation...
-
nils.destoop β
committed 2143656f on 8.x-3.x authored by
DYdave β
- Status changed to Fixed
6 months ago 10:40am 1 June 2024 - π§πͺBelgium nils.destoop
Thx for the merge request. It was merged to main.
Automatically closed - issue fixed for 2 weeks with no activity.