Update for core CSS library changes in 10.3.x

Ok, like the error says, we're expecting an array but got a string. That value (the string) is set in core.libraries.yml, so I'll search for a core issue and create one if I don't find it.

In the meantime I'm setting to 'Needs review' just to test the patch in case anyone needs it.

OTOH, fixing this to be compatible for 10.3 breaks it for previous versions. I can close this issue when it is fixed in core.

calebtr → closed merge request !3

@calebtr can't we just release a version of stable that is only compatible with 10.3+?

Opened 🐛 core.libraries.yml mis-implements moved_files syntax Fixed . Reviews appreciated there (in a few minutes, still preparing the MR). Should result in proper deprecations here instead of fatal errors once it's fixed.

I think once the core bug is fixed, it should be possible for stable to implement overrides for the files both in their old and new locations, and then just remove the old ones once 10.2 support is dropped later on.

Since 🐛 core.libraries.yml mis-implements moved_files syntax Fixed landed I've tested stable 2.0.0 against 10.3.x HEAD and it seems to work with no further changes.

The first system/base component that's loaded on the page is /themes/contrib/stable/css/system/components/ajax-progress.module.css. If i comment this out from the libraries-override section in stable.info.yml it loads this from core/misc/components/ajax-progress.module.css.

In 11.x with and without the patch from MR !3 I get /themes/contrib/stable/css/core/components/ajax-progress.module.css

In 11.x with moved_files keys deleted from core.libraries.yml I get /core/misc/components/ajax-progress.module.css without the patch and /themes/contrib/stable/css/core/components/ajax-progress.module.css with the patch.

So basically for 10.3 we don't necessarily have to do anything here yet, but for 11.x we need to override both locations, as per #9. Setting NW as the MR needs updating to reflect this.

mstrelan → changed the visibility of the branch 3448344-stable-errors-on to active.

We should probably actually move the files here too, not just the references to the core file paths.

Thanks for confirming that fixes things. This also helped me noticed we hadn't done 📌 Remove deprecated moved_files entries in core Active which will remove the bc layer for these specific files. #10 sounds exactly right to me. Re-titling and moving to a task.

Ok, I took a stab at a new MR - though Drupal 10.x-3rc1 has new issues in the drupal.tableheader key. I'll double check this true in dev before creating an issue this time.

I'm glad to know that Stable 2.0 will work when the bug in 10.3 is resolved.

I took a stab at the deprecation messages in the yml comments. Please let me know how they can be improved.

Just as a quick update for your information, the changes outlined in this ticket have been carried over to ticket 📌 Automated Drupal 11 compatibility fixes for stable Needs review to ensure compatibility with the D11.