core.libraries.yml mis-implements moved_files syntax

catch → changed the visibility of the branch 3449302-core-libraries to hidden.

catch → changed the visibility of the branch 3449302- to hidden.

Already removed from 11.x so we just need a 10.4 MR here. Originally thought this was an error with the bc layer itself and was confused because it's tested - it's tested with a theme that correctly implements the syntax.

Is there a way to test it to prevent this kind of errors? for example assert() in parser...

This code only actually gets executed if there is a theme overriding the moved file, this is why it didn't get caught until it was found in the stable theme.

If we wanted to add asserts/validation, we'd need to loop over every library definition when a file is parsed, and check the structure there. We don't do that for the rest of the library definition but I guess we could.. maybe a follow-up to validate everything?

Follow-up could be useful, at least a test to iterate not in production

Can we define/provide a schema for libraries.yml? (or any other custom YAML, for that matter)

Committed and pushed d40360cb42 to 11.x and 1bf09e7490 to 11.0.x and 344c809e05 to 10.4.x and 0f4bafdf2b to 10.3.x. Thanks!

Opened 📌 Validate libraries.yml files Active as followup.

Opened 📌 Remove deprecated moved_files entries in core Active too since those entries should be removed from 11.0.0

I added this to the 10.3.0-rc1 release notes draft as a regression that was resolved from beta1.

Automatically closed - issue fixed for 2 weeks with no activity.