Example recipe isn't functional

thejimbirch → credited jnicola → .

Merge request added. I removed the composer.json file, updated the comments, and made a recipe that can be applied that has the defaults that Drupal core installs so it shouldn't change anything if someone applies it.

I tested it by using it with Drupal quick-start

php core/scripts/drupal quick-start core/recipes/example

Testing process

1. Install Minimal Profile ddev drush si minimal
2. Check Initial Setting ddev drush cget text.settings and confirm it is 600 (default)
3. In the recipe I changed the value of the setting from 600 to 700, to have something different than the default
4. Run Recipe ddev php core/scripts/drupal recipe core/recipes/example
5. Check Setting ddev drush cget text.settings and confirm it is now 700

After manually testing it I wrote and included an automated test that does the same thing

This issue is simple enough. Moving to the core recipe system.

Great! Just tagging Josué for credit for his review/test.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

thejimbirch → changed the visibility of the branch 3447994-example-recipe-isnt to hidden.

Hiding MR 138 as 142 is the correct one.

Moving back to Needs Review to please the bots.

Can we put it back into RBTC or is there something else needed?

Posting a relevant slack thread.

Core contrib question: this issue 🐛 Example recipe isn't functional Active got moved into Needs Work status by a bot. Is there something we can do to get it back to RBTC?

Participants:

Related Issues:

Ah, @mikelutz is correct. THe MR needs to be against core, not the D&R project.

mikelutz → changed the visibility of the branch distributions_recipes-3447994-3447994-example-recipe-isnt-with-test to hidden.

Alright, lets try that one.

Crediting @Josue2591 as he wrote the code. I just opened a new MR against core, cherry picked the commits and (hopefully correctly) fixed some merge conflicts.

Also switching this to major based on "The major priority is used for issues that are not critical, but that do have significant impact or are important by community consensus." As recipes are a hot item right now I would consider having the example recipe be functional for 10.3.0 would be important, but feel free to reduce if I am wrong.

Thanks Mike! Putting back into RBTC.

I think the example recipe does not need to be tested by the installer... hopefully we can have a simpler test.

Akhil Babu → made their first commit to this issue’s fork.

Added a Kernel test for the example recipe as suggested in #24. Also updated simple_config_update to simpleConfigUpdate in the example recipe.

Confirmed recipe is functional and only installing optional config when necessary (tested minimal vs standard) since the test is forcing dependencies (search and views). Tests are also passing. RTBC

Backported down to 10.3.x as it's important to have good examples if people are trying to use this feature in 10.3 or 11.0.

Committed and pushed e9574d73b2 to 11.x and aed5e43a78 to 11.0.x and a225c0a38e to 10.4.x and 38ff4e3ace to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

quietone → closed merge request !8432