- Issue created by @thejimbirch
- Status changed to Needs review
about 1 month ago 12:39pm 18 May 2024 - πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Merge request added. I removed the composer.json file, updated the comments, and made a recipe that can be applied that has the defaults that Drupal core installs so it shouldn't change anything if someone applies it.
I tested it by using it with Drupal quick-start
php core/scripts/drupal quick-start core/recipes/example
- First commit to issue fork.
- Merge request !146Distributions recipes 3447994 3447994 example recipe isnt with test β (Open) created by Josue2591
- π¨π·Costa Rica Josue2591
Testing process
- Install Minimal Profile
ddev drush si minimal
- Check Initial Setting
ddev drush cget text.settings
and confirm it is 600 (default) - In the recipe I changed the value of the setting from 600 to 700, to have something different than the default
- Run Recipe
ddev php core/scripts/drupal recipe core/recipes/example
- Check Setting
ddev drush cget text.settings
and confirm it is now 700
After manually testing it I wrote and included an automated test that does the same thing
- Install Minimal Profile
- Status changed to RTBC
20 days ago 10:50pm 7 June 2024 - πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
This issue is simple enough. Moving to the core recipe system.
- π¨π¦Canada Laura Johnson Toronto
Great! Just tagging JosuΓ© for credit for his review/test.
- Status changed to Needs work
13 days ago 4:16am 15 June 2024 The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
thejimbirch β changed the visibility of the branch 3447994-example-recipe-isnt to hidden.
- Status changed to Needs review
11 days ago 12:00pm 17 June 2024 - πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Hiding MR 138 as 142 is the correct one.
Moving back to Needs Review to please the bots.
- π¨π¦Canada Laura Johnson Toronto
Can we put it back into RBTC or is there something else needed?
- πΊπΈUnited States mikelutz Michigan, USA
Posting a relevant slack thread.
Core contrib question: this issue π Example recipe isn't functional Needs review got moved into Needs Work status by a bot. Is there something we can do to get it back to RBTC?
Participants:
Related Issues:
- Status changed to Needs work
10 days ago 5:06pm 17 June 2024 - πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Ah, @mikelutz is correct. THe MR needs to be against core, not the D&R project.
- πΊπΈUnited States mikelutz Michigan, USA
mikelutz β changed the visibility of the branch distributions_recipes-3447994-3447994-example-recipe-isnt-with-test to hidden.
- Status changed to Needs review
10 days ago 5:23pm 17 June 2024 - πΊπΈUnited States mikelutz Michigan, USA
Crediting @Josue2591 as he wrote the code. I just opened a new MR against core, cherry picked the commits and (hopefully correctly) fixed some merge conflicts.
- πΊπΈUnited States mikelutz Michigan, USA
Also switching this to major based on "The major priority is used for issues that are not critical, but that do have significant impact or are important by community consensus." As recipes are a hot item right now I would consider having the example recipe be functional for 10.3.0 would be important, but feel free to reduce if I am wrong.
- Status changed to RTBC
10 days ago 5:43pm 17 June 2024 - Status changed to Needs work
1 day ago 9:41am 26 June 2024 - π¬π§United Kingdom alexpott πͺπΊπ
I think the example recipe does not need to be tested by the installer... hopefully we can have a simpler test.