Add support for recipes to drupal/recommended-project

thejimbirch → changed the visibility of the branch 3447886-add-support-for to hidden.

Merge request added.

Looks good to me! Could you elaborate on some ways to test?

I'm unable to make this work just by setting "installer-types": ["drupal-recipe"],. Does it need oomphinc/composer-installers-extender?

Yes, thanks! I am not sure core maintainers would want that. If not, we can remove and postpone on the composer/installers pull request.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

The test failed because of cspell on oomphinc.

It looks like Drupal core uses inline comments in files to exclude words from cspell.

But comments aren't allowed in JSON files, so I am not sure how to fix this. Any ideas?

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

It looks like you can add it here, for example egulias is from a package from memory https://github.com/drupal/core/blob/11.x/misc/cspell/dictionary.txt#L218

Thanks! Lets see what the bot thinks of this now.

Can this be rebased for the failures?

Replicated the current error locally, but i'm not really sure why this fails, none of the usual cases seems to apply. If i copy the composer.json to a new directory and run composer update it builds fine. Something about the test context?

  Problem 1
    - Root composer.json requires oomphinc/composer-installers-extender, it could not be found in any version, there may be a typo in the package name.

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://getcomposer.org/doc/04-schema.md#minimum-stability> for more details.
 - It's a private package and you forgot to add a custom repository to find it

Not related to above, but I think it might also need to be added to allowed plugins section?

    "config": {
        "allow-plugins": {
            ...
            "oomphinc/composer-installers-extender": true  
        },

To do this, we also need to bump the composer/installers requirement to ^2.3.

Nice catch, thanks! Updated it.

Do we want to scaffold a readme file?

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Not seeing anything obviously wrong here...let's do it!

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Committed/pushed to 11.1.x, thanks!

If we want to add this to 10.4.x, it'll need a separate MR, but marking fixed for now.

catch → closed merge request !8113

Crediting @thejimbirch - thanks for the initial work on this one!

Automatically closed - issue fixed for 2 weeks with no activity.

This commit caused a problem with contributed module testing. Please read 🐛 PHPCS error in contributed module caused by core recipe README.txt Active and comment there about whether recipe.README.txt is intentionally being copied into [project-root] (and if so, why?), or whether it should be copied into [web-root] instead.