- Issue created by @atul_ghate
- First commit to issue fork.
- Status changed to Postponed: needs info
6 months ago 9:30am 18 May 2024 - 🇧🇪Belgium tim-diels Belgium 🇧🇪
This is not yet included in the default coding standards pipeline from Drupal. So please report what version you're using to get this report.
@shivamsen_12579 why are you taking an issue that is assigned to someone else? Please allow someone who is assigned to an issue to actually work on it.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
@atul_ghate Since this project is using GitLAb CI, it gets PHP_CodeSniffer warnings/errors already reported, and there are no warnings/errors, so far.
If there are changes to do as per coding standards, it is probably better to report them without any reference to PHP_CodeSniffer. - 🇮🇳India atul_ghate
Hi @tim-diels and apaderno, Thank you for the clarification, But I encountered phpcs issue in this MR https://git.drupalcode.org/issue/cloudflare_stream-3446508/-/jobs/1613819 with this version 3.0.x
- Merge request !35Issue #3447783: Fix the warnings/errors reported by PHP_CodeSniffer → (Merged) created by apaderno
- 🇮🇹Italy apaderno Brescia, 🇮🇹
GitLab CI does not report any PHP_CodeSniffer warnings/errors. That is the job ran for this very issue.
- Issue was unassigned.
- Status changed to RTBC
6 months ago 1:00pm 22 May 2024 - 🇧🇪Belgium tim-diels Belgium 🇧🇪
@apaderno, thanks for the information. Looks like this MR is ready to go in. I updated the title to reflect more what this MR does.
-
tim-diels →
committed f5a87eba on 3.0.x authored by
apaderno →
Issue #3447783 by apaderno, tim-diels: Update gitlab CI file
-
tim-diels →
committed f5a87eba on 3.0.x authored by
apaderno →
- Status changed to Fixed
6 months ago 1:03pm 22 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.