- Issue created by @VladimirAus
- Merge request !4Issue #3446747: Correct the sentence used in cookieyes_scripts_help() → (Closed) created by apaderno
- Status changed to Needs review
6 months ago 10:50am 13 May 2024 - Status changed to RTBC
6 months ago 1:46pm 13 May 2024 - Status changed to Needs work
6 months ago 1:59pm 13 May 2024 - Status changed to Needs review
6 months ago 2:26pm 13 May 2024 - 🇦🇺Australia VladimirAus Brisbane, Australia
That makes a bit more sense.
Ready for review. - Status changed to Needs work
6 months ago 6:46pm 13 May 2024 - Merge request !7Issue #3446747: Correct the sentence used in cookieyes_scripts_help() → (Merged) created by apaderno
- Status changed to Needs review
6 months ago 7:23pm 13 May 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
apaderno → changed the visibility of the branch 3446747-correct-the-sentence to hidden.
- 🇦🇺Australia jannakha Brisbane!
I might be a bit confused, but I though the point of git/MR workflow is to review code and comment on other contributors' commits and collaborate, rather than creating new branches/MRs and taking all credit.
But I guess it's not a Drupal way to collaborate.Re: MR4 updates to text/descriptions were valid, the title of the issue could've been updated to indicate the change since it improvement in the textual descriptions, rather than creating bunch of other tasks to update each line of text line/description of code.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
rather than creating new branches/MRs and taking all credit.
If a merge request introduces non pertinent changes, it is probably easier to create a new MR, which is also true when a MR has conflicts with the project branch.
Re: MR4 updates to text/descriptions were valid, the title of the issue could've been updated to indicate the change since it improvement in the textual descriptions, rather than creating bunch of other tasks to update each line of text line/description of code.
Except that the first revision for this issue was Improve hook_help() in the module. and those changes were off-topic. Issues are created by topic; they cannot be "Let's change everything that needs to be changed." issues.
Furthermore, if somebody complains about "off-topic changes done by somebody else," they should not then do off-topic changes either. - 🇦🇺Australia jannakha Brisbane!
then why not create new issue for the code that you've just discarded?
all this looks just silly game for some gold stars. good luck.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Gold stars? I apologize, but before making "accusations," you should first check facts. I don't get gold stars.
As for creating issues, I am already creating issues for changes I think should be done.
-
apaderno →
committed cf9709f6 on 2.0.x
Issue #3446747: Correct the sentence used in cookieyes_scripts_help()
-
apaderno →
committed cf9709f6 on 2.0.x
- Status changed to Fixed
6 months ago 10:47am 6 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.