- Issue created by @Liam Morland
- Status changed to Needs review
about 2 months ago 1:59pm 9 May 2024 - 🇦🇺Australia VladimirAus Brisbane, Australia
VladimirAus → changed the visibility of the branch 2.0.x to hidden.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
I have rebased, disabled a test, and used just the default template for
.gitlab-ci.yml. These changes allow the tests to pass.Since there are currently no automated tests being run, it would be great to get this committed so at least most of the tests are running. The disabled test can be re-enabled later once it is fixed. As well, the stricter coding standards tests can be enabled once they pass.
- Status changed to Needs work
about 1 month ago 9:01am 24 May 2024 - 🇦🇺Australia VladimirAus Brisbane, Australia
Test should fail if they don't pass especially for phpcs.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
A good way to start is to get tests running based on the default template. This will help prevent regressions because any new pull requests will have tests run on them. This allows adopting the practice of not merging pull requests unless the tests pass.
Then work on getting phpcs, etc. to pass without any warnings. Once each passes without warnings, the warnings can be upgraded to an error.
I don't have any more time to work on getting phpcs, etc. to pass.