- Issue created by @brianperry
- ๐บ๐ธUnited States cosmicdreams Minneapolis/St. Paul
It this is what we want then we should also require that this module uses Drupal 10.3 instead of 10.1. If someone WAS using Drupal 10.1 then they would need to enable the experimental module.
- ๐จ๐ฆCanada mandclu
The README does specify that the module can be used with Drupal 10.1 or 10.2 but the experimental SDC module needs to be enabled manually.
- ๐ฌ๐งUnited Kingdom rachel_norfolk UK
Just re-tagging with the official tag :-)
- ๐บ๐ธUnited States brianperry
Could see either side on this one, but I'd rather not restrict the audience for this module again. It does add a potential hiccup for pre 10.3 users, but I think the benefit of a wider potential audience outweighs the risk.
- ๐บ๐ธUnited States cosmicdreams Minneapolis/St. Paul
Removing SDC doesn't appear to have an impact on newer version of Drupal. (works in starshot as is). Perhaps if it were to cause a problem in newer version of Drupal, that is when we should consider removing it.
In other words, what is the harm in keeping our requirements as is?
- ๐บ๐ธUnited States brianperry
If you enable through the UI it will give a warning about enabling experimental modules. And generally Iโd imagine it isnโt uncommon for projects to not allow experimental modules. It also canโt be disabled because it is an explicit dependency.
Neither situation is perfect, but I still think weโre better off removing the dependency.
- ๐บ๐ธUnited States cosmicdreams Minneapolis/St. Paul
It's fair.
Here's what I think:
1. We create a new version that's should be the one that people get for new Drupal versions.
2. We keep the current version "stuck in the past", when sdc was experimental. - ๐บ๐ธUnited States brianperry
@cosmicdreams are you talking about a regular tagged release here, or a major version / breaking change?
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
on drupal 11 things with sdc not only look odd but are actively blocking the install. if you are trying to install same page preview on drupal 11.0.1, the composer require step works but you are unable to actually install 2.1.4 because of sdc is missing.
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
liam morland โ made their first commit to this issueโs fork.
Automatically closed - issue fixed for 2 weeks with no activity.