Remove Experimental SDC Dependency

Created on 9 May 2024, 8 months ago
Updated 28 August 2024, 4 months ago

Problem/Motivation

SDC is in core and not a standalone module as of 10.3. But this module still has the experimental version of SDC as a dependency. It looks odd when installing via the UI.

Steps to reproduce

Install Same Page Preview via the UI. See a message about needing to enable the experimental Single Directory Components module.

Proposed resolution

Remove this dependency. That does put 10.1 and 10.2 in a bit of an odd place. Rather than restricting this module to 10.3, I updated the readme to mention that in earlier versions the experimental SDC module needs to be enabled manually.

๐Ÿ“Œ Task
Status

Active

Version

2.1

Component

Code

Created by

๐Ÿ‡บ๐Ÿ‡ธUnited States brianperry

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @brianperry
  • Merge request !62Remove Experimental SDC Dependency โ†’ (Merged) created by brianperry
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States cosmicdreams Minneapolis/St. Paul

    It this is what we want then we should also require that this module uses Drupal 10.3 instead of 10.1. If someone WAS using Drupal 10.1 then they would need to enable the experimental module.

  • ๐Ÿ‡จ๐Ÿ‡ฆCanada mandclu

    The README does specify that the module can be used with Drupal 10.1 or 10.2 but the experimental SDC module needs to be enabled manually.

  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom rachel_norfolk UK

    Just re-tagging with the official tag :-)

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States brianperry

    Could see either side on this one, but I'd rather not restrict the audience for this module again. It does add a potential hiccup for pre 10.3 users, but I think the benefit of a wider potential audience outweighs the risk.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States cosmicdreams Minneapolis/St. Paul

    Removing SDC doesn't appear to have an impact on newer version of Drupal. (works in starshot as is). Perhaps if it were to cause a problem in newer version of Drupal, that is when we should consider removing it.

    In other words, what is the harm in keeping our requirements as is?

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States brianperry

    If you enable through the UI it will give a warning about enabling experimental modules. And generally Iโ€™d imagine it isnโ€™t uncommon for projects to not allow experimental modules. It also canโ€™t be disabled because it is an explicit dependency.

    Neither situation is perfect, but I still think weโ€™re better off removing the dependency.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States cosmicdreams Minneapolis/St. Paul

    It's fair.

    Here's what I think:

    1. We create a new version that's should be the one that people get for new Drupal versions.
    2. We keep the current version "stuck in the past", when sdc was experimental.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States brianperry

    @cosmicdreams are you talking about a regular tagged release here, or a major version / breaking change?

  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany rkoller Nรผrnberg, Germany

    on drupal 11 things with sdc not only look odd but are actively blocking the install. if you are trying to install same page preview on drupal 11.0.1, the composer require step works but you are unable to actually install 2.1.4 because of sdc is missing.

  • ๐Ÿ‡จ๐Ÿ‡ฆCanada Liam Morland Ontario, CA ๐Ÿ‡จ๐Ÿ‡ฆ

    liam morland โ†’ made their first commit to this issueโ€™s fork.

  • ๐Ÿ‡จ๐Ÿ‡ฆCanada Liam Morland Ontario, CA ๐Ÿ‡จ๐Ÿ‡ฆ

    Rebased

  • ๐Ÿ‡จ๐Ÿ‡ฆCanada Liam Morland Ontario, CA ๐Ÿ‡จ๐Ÿ‡ฆ
  • Pipeline finished with Success
    3 months ago
    Total: 141s
    #301119
  • Pipeline finished with Success
    3 months ago
    Total: 157s
    #301126
  • Pipeline finished with Success
    3 months ago
    Total: 171s
    #301129
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States cosmicdreams Minneapolis/St. Paul
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States cosmicdreams Minneapolis/St. Paul
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024