Missing modules after updating from 2.0.10 to 2.0.11

I went on and
- required the 2 modules again via composer,
- uninstalled them via drupal
- and then removed them again via composer.

It is fine now but something is not handled correctly between 2.0.10 and 2.0.11 as I understand.

I had the same issue after the troublesome update to 2.0.10 and then 2.0.11, as described in https://www.drupal.org/project/taxonomy_manager/issues/3444071 🐛 Version 2.0.10 breaks existing installations Needs work .

After trying many things without success, I uninstalled and removed Taxonomy Manager completely:

drush pmu taxonomy_manager
drush pmu term_merge
drush pmu term_reference_change

Removed taxonomy_manager from (`composer remove taxonomy_manager` didn't work. I don't know why)
Removed taxonomy_manager patch 🐛 Version 2.0.10 breaks existing installations Needs work from composer.json

composer update
drush updb
drush cr

Then I installed taxonomy_manager 2.0.11 again:

composer require 'drupal/taxonomy_manager:^2.0'
drush en taxonomy_manager

Now I have a new but related issue. If I expand 'Taxonomy Manager Merge' at /admin/modules it says 'term_merge is missing'. I am not sure why that is, because term_merge is required in /taxonomy_manager/modules/taxonomy_manager_merge/composer.json.

Happy to open this as a separate issue if necessary.

Yes I can see the same notice under Taxonomy Merge Manager but it is obviously because of the dependency declared in
taxonomy_manager_merge.info.yml

name: 'Taxonomy Manager Merge'
description: 'Intergrate Merge Terms with Taxonomy Manager'
core_version_requirement: ^10
dependencies:
  - taxonomy_manager:taxonomy_manager
  - term_merge:term_merge
package: Taxonomy
type: module

I don't know why composer is not installing term_merge. It is required in taxonomy_manager_merge/composer.json.

I don't have experience with the matter but maybe the composer requirement has to go to the main composer.json because when requiring the taxonomy manager obviously composer isn't looking in subfolders.

Hey Nick Hope!
So, I suggest following steps from https://www.drupal.org/project/taxonomy_manager/issues/3445744#comment-1... 🐛 Missing modules after updating from 2.0.10 to 2.0.11 RTBC
In nutshell:
1. Use composer to include term_merge and term_reference_change
2. Enable those modules using drush en -y term_merge term_reference_change
3. Uninstall them drush pmu -y term_merge term_reference_change
4. Clear cache
5. Remove modules from composer

I think it should help, sounds like you have some config left-overs.

Well as I see in the following issues, what I was suspecting is the situation: the dependecies for the submodules should be added to the main module composer file.
https://www.drupal.org/project/linkback/issues/2959975 →
https://www.drupal.org/project/project_composer/issues/3304661 🌱 Change how modules and submodule dependencies are handled to have more consistent namepsaces [DRAFT]. Active

So there are two options as I understand:
1. either add the dependecies of the submodule in the main module's composer file
2. or spin of the submodule into a entirely separate module

Well, the original idea was to have a merge functionality as part of the main module.
I don't know if having it now in the main module composer dependencies is the right approach.
Maybe, would be enough to update module REAMDE.md and provide a note about requiring term merge and term_reference_change manually.

@Andriy Khomych This doesn't seem to be due to config leftovers. The issue happens on a fresh install of Taxonomy Manager on a test site. 'term_merge (missing)' is shown If I expand 'Taxonomy Manager Merge' at /admin/modules. It can be resolved by installing term_merge manually:

composer require 'drupal/term_merge:^2.0@beta'
drush en term_merge

p.s. Thank you for your efforts in improving Taxonomy Manager.

Personally, I prefer not to have to manually install a separate module to achieve the merge functionality. So I would tend towards the option of adding the dependencies of the submodule in the main module's composer file. But will that cause problems with minimum stability level because term_merge and term_reference_change are both still in beta, and taxonomy_manager is not? (I don't have the experience to know)

Another option might be to make a 2.0.12 that reverts to 2.0.9 (removing merge functionality and dependencies), and also make a 2.1.0-beta1 that includes merge. But care would be needed not to leave users with more config issues. I guess the consensus might be that it is now too late for that approach.

> p.s. Thank you for your efforts in improving Taxonomy Manager.
My pleasure.

> Personally, I prefer not to have to manually install a separate module to achieve the merge functionality. So I would tend towards the option of adding the dependencies of the submodule in the main module's composer file. But will that cause problems with minimum stability level because term_merge and term_reference_change are both still in beta, and taxonomy_manager is not? (I don't have the experience to know)

This is unfortunate, but it is known Drupal limitation regarding submodules, let's hope it can be fixed in the future.

> Another option might be to make a 2.0.12 that reverts to 2.0.9 (removing merge functionality and dependencies), and also make a 2.1.0-beta1 that includes merge. But care would be needed not to leave users with more config issues. I guess the consensus might be that it is now too late for that approach.

Yeah, it is too late for this, I tried to keep this option built-in, but due to the critical status of the issue and discussing it with another maintainer we agreed to use submodule.
Moving to fixed now.

@Andriy Khomych But the problem of missing term_merge is not resolved.

As far as I can tell, one of @arx-e's suggestions in #8 should be done. If you plan not to do either of those, then there should at least be clear instructions in the module description and Readme file that term_merge must be installed and enabled separately.

By the way, the module description still refers to 7.x only with regard to merge: "merging of terms (using the Term merge module in 7.x)".

Andriy Khomych → changed the visibility of the branch 3445744-missing-modules-after to hidden.

Andriy Khomych → changed the visibility of the branch 3445744-missing-modules-after to active.

> As far as I can tell, one of @arx-e's suggestions in #8 should be done. If you plan not to do either of those, then there should at least be clear instructions in the module description and Readme file that term_merge must be installed and enabled separately.

I don't know if it is the right approach, generally, I don't like the idea of getting all dependencies in the composer if they are not used.
So, I'll update README.md and let's community decide this in the future.
BTW, I cannot update the module README, so we can move it to RTBC.

Added to dev version README updates.

Since this is merged, why is it marked RTBC?

It would be great to have another opinion here based on https://www.drupal.org/project/taxonomy_manager/issues/3445744#comment-1... 🐛 Missing modules after updating from 2.0.10 to 2.0.11 RTBC

Well, no opinions, so we can mark it as fixed.

Automatically closed - issue fixed for 2 weeks with no activity.