Compatibility with Drush 13

Created on 7 May 2024, 8 months ago
Updated 31 May 2024, 7 months ago

Problem/Motivation

In Drush 13 Drush\Drupal\Commands\sql\SanitizePluginInterface was moved to Drush\Commands\sql\sanitize.

This results in the following error:
[error] Error: Interface "Drush\Drupal\Commands\sql\SanitizePluginInterface" not found in include() (line 18 of /data/app/modules/contrib/webform/src/Commands/WebformSanitizeSubmissionsCommands.php) #0 /data/vendor/composer/ClassLoader.php(576): include()

See Stop using drush.services.yml in sql:sanitize plugins where the change was introduced.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Needs work

Version

6.2

Component

Code

Created by

🇦🇺Australia mstrelan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mstrelan
  • 🇮🇳India Rajan Kumar@2026

    Rajan Kumar@2026 made their first commit to this issue’s fork.

  • 🇮🇳India Vighneshh

    updated a patch for this issue please Review.

  • Merge request !466added version d11 → (Open) created by Rajan Kumar@2026
  • Open on Drupal.org →
    Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
    last update 8 months ago
    Waiting for branch to pass
  • Status changed to Needs review 8 months ago
  • Open on Drupal.org →
    Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
    last update 8 months ago
    Waiting for branch to pass
  • 🇮🇳India Rajan Kumar@2026

    Hellow, @mstrelan @quicksketch

    Added Drupal version for 11

    I have created MR , please kindly review it once.

  • Pipeline finished with Success
    8 months ago
    Total: 2288s
    #166041
  • Status changed to Needs work 8 months ago
  • 🇦🇺Australia mstrelan

    @Vighneshh we need some kind of backwards compatibility, will need more thought than simply changing the namespace. Also the screenshots are not helpful and I'm sure the maintainer would prefer merge requests over patches.

    @Rajan Kumar@2026 that is not in scope here.

  • 🇦🇺Australia mstrelan

    mstrelan changed the visibility of the branch 3445590-compatibility-with-drush to hidden.

  • First commit to issue fork.
  • 🇦🇺Australia sime Melbourne

    Thoughts

    What is the minimum version of drush required by webform? Because we should convert commands to PHP8 annotations and drop the drush.services.yml.

    If annotations allow to specify compatibility with a version of drush, then make a deprecated command file for drush <=12 and keep the current one (with the fix) for >13.

  • 🇵🇹Portugal jcnventura

    Simplest way to solve this issue is to fix it in Drush. Please upvote my request: https://github.com/drush-ops/drush/issues/6018

  • 🇦🇺Australia sime Melbourne
  • Pipeline finished with Success
    6 months ago
    Total: 303s
    #222968
  • Pipeline finished with Success
    6 months ago
    #222969
  • Pipeline finished with Success
    6 months ago
    Total: 185s
    #222981
  • Pipeline finished with Failed
    15 days ago
    Total: 7612s
    #365621
  • Pipeline finished with Failed
    15 days ago
    Total: 658s
    #365773
  • Pipeline finished with Failed
    15 days ago
    Total: 665s
    #365894
  • Pipeline finished with Failed
    15 days ago
    Total: 631s
    #365964
  • Pipeline finished with Failed
    15 days ago
    Total: 629s
    #365977
  • Pipeline finished with Failed
    15 days ago
    Total: 937s
    #366063
  • Pipeline finished with Canceled
    14 days ago
    Total: 69s
    #366721
  • Pipeline finished with Failed
    14 days ago
    Total: 654s
    #366723
  • Pipeline finished with Failed
    14 days ago
    Total: 777s
    #366738
  • Pipeline finished with Failed
    14 days ago
    Total: 647s
    #366763
  • Pipeline finished with Failed
    14 days ago
    Total: 489s
    #366792
  • Pipeline finished with Failed
    14 days ago
    Total: 717s
    #366801
  • Pipeline finished with Success
    14 days ago
    Total: 873s
    #366854
  • Pipeline finished with Failed
    14 days ago
    Total: 665s
    #366878
  • Pipeline finished with Success
    14 days ago
    Total: 653s
    #366944
  • Pipeline finished with Failed
    14 days ago
    Total: 643s
    #366958
  • Pipeline finished with Failed
    14 days ago
    Total: 5320s
    #366896
  • Pipeline finished with Failed
    14 days ago
    Total: 1983s
    #366977
  • Pipeline finished with Success
    14 days ago
    Total: 652s
    #367004
  • Pipeline finished with Success
    14 days ago
    Total: 2489s
    #367019
  • Pipeline finished with Success
    14 days ago
    Total: 811s
    #367048
Production build 0.71.5 2024