- Issue created by @jannakha
- 🇦🇺Australia jannakha Brisbane!
jannakha → changed the visibility of the branch 3445501-location-of-js to hidden.
- 🇦🇺Australia jannakha Brisbane!
jannakha → changed the visibility of the branch 3445501-script-insert-d10 to hidden.
- Merge request !1Resolve #3445501 "Location of JS injection (in body) is invalid" → (Closed) created by jannakha
- First commit to issue fork.
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
8 months ago Waiting for branch to pass - Status changed to Needs review
8 months ago 12:47pm 8 May 2024 - 🇦🇺Australia jannakha Brisbane!
Merge conflict is because of issue #3445605 →
MR!1 is ready to merge after #3445605 is resolved
- Status changed to RTBC
8 months ago 2:09am 11 May 2024 - 🇦🇺Australia VladimirAus Brisbane, Australia
Looks good. Ready to be merged.
Merge conflict due to incorrect tag name that clashes with branches. - Status changed to Needs work
8 months ago 6:59pm 11 May 2024 - Merge request !2Issue #3445501: Location of JS injection (in body) is invalid → (Closed) created by apaderno
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
8 months ago Waiting for branch to pass - Status changed to Needs review
8 months ago 7:35pm 11 May 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
apaderno → changed the visibility of the branch 3445501-script-insert-d10-2 to hidden.
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
8 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
8 months ago Waiting for branch to pass - 🇦🇺Australia VladimirAus Brisbane, Australia
@apaderno please read issue description and create separate tasks for CI and help and other issues.
- 🇦🇺Australia VladimirAus Brisbane, Australia
VladimirAus → changed the visibility of the branch 3445501-fix-js-location to hidden.
- Status changed to Needs work
7 months ago 5:36am 13 May 2024 - 🇦🇺Australia VladimirAus Brisbane, Australia
VladimirAus → changed the visibility of the branch 3445501-script-insert-d10-2 to active.
- Status changed to Needs review
7 months ago 5:56am 13 May 2024 - Status changed to RTBC
7 months ago 6:17am 13 May 2024 - 🇦🇺Australia jannakha Brisbane!
@apaderno - please do not add unrelated to issue fixes into the branch - it makes it really hard to review as it's out of scope of the issue.
@vladimirAus thanks for fixing the repo
- 🇮🇹Italy apaderno Brescia, 🇮🇹
apaderno → changed the visibility of the branch 3445501-fix-js-location to active.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
apaderno → changed the visibility of the branch 3445501-script-insert-d10-2 to hidden.
- Status changed to Needs review
7 months ago 9:53am 13 May 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
@jannakha Who commited code in a MR cannot change the status to Reviewed & tested by the community.
Before doing that, somebody should check the MR correctly changes the code following the Drupal coding standards, which says the name to use for functions, and where the opening curly parenthesis for a function is placed. - 🇮🇹Italy apaderno Brescia, 🇮🇹
apaderno → changed the visibility of the branch 3445501-fix-js-location to hidden.
- Assigned to apaderno
- Merge request !12Issue #3445501: The wrong hook is used to attach JavaScript code → (Merged) created by apaderno
-
apaderno →
committed a65634f9 on 2.0.x
Issue #3445501: The wrong hook is used to attach JavaScript code
-
apaderno →
committed a65634f9 on 2.0.x
- Issue was unassigned.
- Status changed to Fixed
7 months ago 5:51pm 6 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.