- Issue created by @raffaelj
- Assigned to Rajan Kumar@2026
- 🇮🇳India Rajan Kumar@2026
Rajan Kumar@2026 → changed the visibility of the branch 3445444-unit-tests-are to hidden.
- Status changed to Needs review
8 months ago 12:31pm 6 May 2024 - 🇮🇳India Rajan Kumar@2026
Hi, @raffaelj @raffaelj
fixed according to compatible with Drupal 11
I have fixed the issue and created MR , please kindly review it once.
- Issue was unassigned.
- Status changed to Needs work
8 months ago 1:09pm 6 May 2024 @rajan-kumar2026: Well... Thanks for your effort, I guess?
You created a merge request with the automatically generated patch from 📌 Automated Drupal 11 compatibility fixes for disable_libraries Active , which marks this module as compatible with Drupal 11. But this issue is about incompatible unit tests with extracted notes from the linked patch and diff files in that issue.
Before I mark this module as compatible with v11, I have to manually test it and I have to fix at least the two mentioned issues.
I'm sorry, if this sounds rude, but... Are you credit farming? Because you obviously didn't read the issue summary.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
apaderno → changed the visibility of the branch 3445444- to hidden.
- 🇮🇳India Rajan Kumar@2026
Hi, @raffaelj
Composer.js file already contains "require": {
"drupal/core": "^10"
}If I do this it may fix the issue
"require": {
"drupal/core": "^11"
} - Assigned to raffaelj
- Status changed to Active
8 months ago 5:07pm 9 May 2024 @rajan-kumar2026: This still doesn't fix anything. You can't just randomly change version numbers and expect to fix incompatibilities between versions.
I'm not in the mood right now to teach you the very basics of composer version constraints, how .info.yml files act as an abstraction for composer usage in Drupal land, how PHP and Drupal work in general and what unit tests are. Please ask your coworkers to give you some basic tutorials.
I assigned myself now to make it clear, that I want to fix this issue myself. But I'm not in a hurry, because there are more than two months left before Drupal 11 will be released.
After properly testing this module for compatibility, it's time to update composer.json and .info.yml with the new version constraint.
Besides that: I don't think it's fair to talk publicly about you without your knowledge. Because of your low quality contributions, I thought you would try to game the system for credit farming. Now I think, that you just want to help, but that Drupal is a bit too complicated for your first steps in open source contributions. See: #3445549: Credit farming of rajan-kumar2026 →
-
raffaelj →
committed 67aaa8e0 on 0.x
fixed d11 unit test incompatibilities, fixes #3445444
-
raffaelj →
committed 67aaa8e0 on 0.x
- Issue was unassigned.
- Status changed to Fixed
8 months ago 2:51pm 10 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.