Contrib.social

Automated Drupal 11 compatibility fixes for disable_libraries

Open on Drupal.org →
Created on 29 April 2024, 7 months ago
Updated 14 July 2024, 4 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

0.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Project Update Bot
  • Comment 7 months ago →
    Project Update Bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-158321

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.2.0
    2. mglaman/phpstan-drupal: 1.2.10
    3. palantirnet/drupal-rector: 0.20.1
  • Status changed to Active 7 months ago
  • Comment 7 months ago →
    raffaelj

    See https://www.drupal.org/project/disable_libraries/issues/3445444 📌 Unit tests are incompatible with Drupal 11 Active

  • Comment 6 months ago →
    Project Update Bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-177898

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.1
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !3Automated Project Update Bot fixes → (Open) created by Project Update Bot
  • Status changed to Needs review 6 months ago
  • Status changed to Fixed 5 months ago
  • Comment 5 months ago →
    raffaelj

    comparing commit history of 10.3.x branch with 11.x branch (2024-06-30)

    • [x] manual diff \Drupal\Core\Asset\LibraryDiscoveryCollector --> no changes
    • [x] manual diff \Drupal\Core\Theme\ThemeInitialization --> no relevant changes (only deprecated code was removed

    setup a local Drupal 11 test instance and run tests - This was a pain and took me multiple hours because of: 🐛 PHPUnit 10 behaves differently when invoked outside web root Needs review 

    mkdir test && cd test
composer create-project drupal/recommended-project:11.0.0-beta1@beta .
composer require --dev drupal/core-dev
composer require drush/drush

mkdir -p web/modules/contrib
git clone https://git.drupalcode.org/project/disable_libraries.git web/modules/contrib/disable_libraries

mkdir -p db
./vendor/bin/drush site:install --yes --db-url="sqlite://../db/test.sqlite"
# save password for later... 725ViHSaE2

./vendor/bin/drush pm:install disable_libraries

cp ./web/core/phpunit.xml.dist ./web/core/phpunit.xml
sed -i -E 's~<env name="SIMPLETEST_DB" value=""/>~<env name="SIMPLETEST_DB" value="sqlite://../../db/kernel-test.sqlite"/>~g' ./web/core/phpunit.xml

sed -i -E 's~"drupal/core": "^10"~"drupal/core": "^10 | ^11"~g' web/modules/contrib/disable_libraries/composer.json
sed -i -E 's~core_version_requirement: ^10~core_version_requirement: ^10 | ^11~g' web/modules/contrib/disable_libraries/composer.json

cd web
../vendor/bin/phpunit -c core/phpunit.xml modules/contrib/disable_libraries/tests/src/Kernel/LibraryDisablerTest.php
../vendor/bin/phpunit -c core/phpunit.xml modules/contrib/disable_libraries/tests/src/Unit/LibraryDisablerTest.php
    • [x] unit tests
    • [ ] kernel tests

    Kernel test passed for some reason when running from host system (sqlite3 v3.39.2), but failed when running from dev docker image (sqlite3 v3.40.1). Both should have failed because v3.45 is required. Because the kernel test doesn't test anything important (yet), this can be ignored.

    So this module is compatible with Drupal 11.

    Compatibility notice added in 0.1.4 - https://git.drupalcode.org/project/disable_libraries/-/commit/9add8dc78f...

  • Comment 4 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024