Created on 2 May 2024, 7 months ago
Updated 28 May 2024, 6 months ago

Problem/Motivation

dell@dell-Latitude-E5470:/var/www/html/phpcs$ ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig ~/projects/newd10/web/modules/contrib/instagram_feeds_listing

FILE: /home/dell/projects/newd10/web/modules/contrib/instagram_feeds_listing/src/InstagramBasicDisplayApi.php
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
111 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------

FILE: /home/dell/projects/newd10/web/modules/contrib/instagram_feeds_listing/src/Form/InstagramFeedAdminForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 13 WARNINGS AFFECTING 13 LINES
------------------------------------------------------------------------------------------------------------------------------------------
45 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
53 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
68 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
75 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
80 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
87 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
93 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
103 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
111 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
117 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
124 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
130 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
151 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------

Time: 157ms; Memory: 10MB

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

šŸ› Bug report
Status

RTBC

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India sarwan_verma

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @sarwan_verma
  • Assigned to dev16.addweb
  • Merge request !2Resolved #3444757 "Phpcs error" ā†’ (Open) created by Unnamed author
  • Issue was unassigned.
  • Status changed to Needs review 6 months ago
  • šŸ‡®šŸ‡³India dev16.addweb

    I have created MR, Please review.

  • Status changed to RTBC 6 months ago
  • šŸ‡µšŸ‡­Philippines paraderojether

    Hi silvi.addweb,

    I reviewed MR!2, applied it against Instagram Feeds Listing 1.0.0 and confirmed it fixes the issues reported by phpcs.

    instagram_feeds_listing git:(main) āœ— curl https://git.drupalcode.org/project/instagram_feeds_listing/-/merge_requests/2.diff | patch -p1   
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100  6820    0  6820    0     0  13750      0 --:--:-- --:--:-- --:--:-- 14004
    patching file 'src/Form/InstagramFeedAdminForm.php'
    patching file 'src/InstagramBasicDisplayApi.php'
    āžœ  instagram_feeds_listing git:(main) āœ— cd ..
    āžœ  contrib git:(main) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig instagram_feeds_listing
    āžœ  contrib git:(main) āœ— 

    Thank you.

Production build 0.71.5 2024