Refactor JSON-API file uploads to use FileUploadHandler

This is postponed on 📌 Refactor FileUploadResource to use FileUploadHandler RTBC as we are adding some new classes there that we will need here.

📌 Refactor FileUploadResource to use FileUploadHandler RTBC is in so this is unblocked. 🙌

one test failed and I left a question for constructor's BC

Created MR for 10.4.x with BC layer.

Feedback addressed and MR for 10.4.x created with BC layer.

Awesome to see this moving!

Quick contrib search:

1. jsonapi/Controller/FileUpload - 0 usage
2. jsonapi\Controller\TemporaryJsonapiFileFieldUploader - 0 usage
3. jsonapi.file_upload - 1 usage

Seems we are not really doing anything impactfull against contrib.

I've checked the CR, its small, but fine i think.

BC paths make sense for new arguments for the controller.

Gone though the code, have some questions :) This feels rather close, and i'll be quite happy to have the "Temporary" class killed :D

Thanks for the review. I've addressed all feedback.

This feels rather close, and i'll be quite happy to have the "Temporary" class killed :D

Committed on 20 Mar 2019 so temporary for 5 years. 🤣

Everything in #11 has been adressed.

Think this is fine. BC is a bit hard to fully consider, but i think we have enough. All threads have been resolved, RTBC for me <3

Can we change the 10.4.x deprecations to be for 10.3.x - I think it is the best option because I think doing 10.3.x deprecation and remove in 11 would put us in a better situation wrt to security. Having something that can do file uploads around for the whole 11.x cycle that is unused and untested feels like a v bad idea.

Sounds like a playing. I'll wait for Kim to update and review the changes.

Changed to `drupal:10.3.0` for removal in `drupal:11.0.0`.

You still need to chnage the target of the mr I think. It's still targeting 10.4

@bbrala as long as it applies to 10.3.x we're fine - and it will. Given this only text changes I think the rtbc from #13 stands.

Committed and pushed a52cdfad63 to 11.x and 007556a098 to 11.0.x. Thanks!
Committed and pushed b10e96de15 to 10.4.x and be2b4ec313 to 10.3.x. Thanks!

Oh wow. This wraps up years of effort unifying file uploads. 🥲

Hehe, thanks Alex :)

Congrats Kim! :)

Automatically closed - issue fixed for 2 weeks with no activity.

kim.pepper → closed merge request !7915

kim.pepper → closed merge request !7918