Refactor FileUploadResource to use FileUploadHandler

Found a mismatch in behaviour with the filename field on the File entity not being updated when we do a rename.

I think this is now blocked on 🐛 Filename property is not updated when a file is renamed FileUploadResource Active

Created a MR that combines 🐛 Filename property is not updated when a file is renamed FileUploadResource Active

Blocker is in

There is a test failure due to a behaviour change. I'm scratching my head to work out why.

Before: example.php gets renamed:
example.php => example.php_.txt

After: example.php gets rejected because the .php extension isn't in the allow extensions list.

Many thanks to @larowlan for helping resolve the file extensions issues. 🙌🏻🥳

This is ready for reviews now.

Changing this to critical as it is a part of 📌 [PP-4] Unify file upload logic of REST and JSON:API Postponed which is critical.

Added a review to the MR... this is looking lovely.

pradhumanjain2311 → made their first commit to this issue’s fork.

@alexpott are you happy if we look into your concerns in 📌 Simplify how 'allow all extensions' file upload validation works Active ?

Re #11 yeah - I don't think your code is changing any of the current behaviour ... it's just whenever I see code allowing all extensions I get very security nervous.

Re-organizing parent meta issue.

Once this goes in, we can start on 📌 [PP-1] Refactor JSON-API file uploads to use FileUploadHandler Postponed

This looks great, unifying all this is definitely the way to go, but the patch does not apply to 10.3.x/10.4.x so we will need a separate MR.

I'm also in two minds about removing the deprecation in 11.x at this stage. https://www.drupal.org/project/file_upload_options → does extend this plugin in contrib but only has a beta release and 123 users.

If we do remove the deprecation in 11.x then we will need an 11.x MR with the deprecations removed. Otherwise, the deprecations need updating to 12.x

I think since it is constructor deprecations and not actually covered by our BC promise we should deprecate in 10.x and remove in 11.x. Contrib does not need to override the constructor - they can do what they need in the create method.

Removed deprecations from the 11.x branch and created an 10.4.x branch resolving the conflict.

Couple of deprecations still in the 11.x branch - other than that looks good to me

removed the deprecated functions from 11.x branch. nice catch @larowlan

Committed f757b3d and pushed to 11.x. Thanks!

Committed and pushed 8f38f5d839 to 10.4.x and 48c58073ee to 10.3.x. Thanks!

longwave → closed merge request !5487

longwave → closed merge request !7884

Woohoo! 🎉 See you in 📌 [PP-1] Refactor JSON-API file uploads to use FileUploadHandler Postponed

We left in the method InputStreamUploadedFile::supportsMoveUploadedFile() from an approach that we ditched in favour of the InputStreamUploadedFile::validate() approach. Created 🐛 Remove incorrectly added InputStreamUploadedFile::supportsMoveUploadedFile() Active to clean this up.

Automatically closed - issue fixed for 2 weeks with no activity.