- Issue created by @SKAUGHT
- 🇨🇦Canada SKAUGHT
🐛 Enhance Navigation admin workflow with Managed Tabs. Needs review will be adding a 'NavigationBaseTest' item when accepted.
- First commit to issue fork.
- Status changed to Needs review
8 months ago 12:23am 2 May 2024 - 🇨🇦Canada m4olivei Grimsby, ON
Ready for review. While here I also made the selector more explicit for the assertion.
- Status changed to Closed: won't fix
8 months ago 5:34am 2 May 2024 - 🇪🇸Spain plopesc Valladolid
Thank you for your efforts here.
Unfortunately, navigation_top_bar is just an instrumental module to prevent access to the experimental top bar unless site administrators assume all the possible risks.
It means that all the code and logic should remain in the navigation module to make the transition form experimental to stable as simple as possible avoiding BC breaks.
Discussion about strategy and implementation can be found at 📌 Create feature flag module to control navigation top bar visibility Fixed .
Marking it as won't fix because moving code to navigation_top_bar module is discouraged.
Selector improvements in the test are nice, but I believe we can introduce them as part of a different top bar related issue, like 🐛 Navigation Top Bar hides entity local tasks even if the user has no access to the bar Active
- 🇨🇦Canada SKAUGHT
thanks @plopesc
I myself am understanding more about what's happening with these tests, as we all are.