- Issue created by @plopesc
- Merge request !256Issue #3442059: Convert Top Bar into an experimental submodule → (Open) created by plopesc
- 🇪🇸Spain plopesc Valladolid
Backend part is ready for review. We need now to ensure that Top Bar specific styles are moved to the submodule.
- 🇪🇸Spain ckrina Barcelona
Working on the front-end for this.
I wonder if the should call this module just "top_bar" instead of "navigation_top_bar".
- Status changed to Needs review
8 months ago 4:43pm 21 April 2024 - 🇬🇧United Kingdom catch
This might be a good idea, but it's not what I asked for in ✨ Add the new Navigation to core as an Experimental module Fixed , all I was suggesting was a feature flag module per ✨ Add an API for feature flags Active and 📌 Replace "Expose all fields as blocks to Layout Builder" configuration with feature flag Active - i.e. using the module being installed or not to determine whether the feature is enabled, instead of custom config. If the top bar should never be enabled independently of the navigation module once everything is stable, then moving it into and out of a module might be too much extra work compared to just a feature flag module. Apologies if this wasn't clear on the other issue.
- 🇷🇸Serbia finnsky
Probably here we also need to add checking if this topBar module not enabled then render some div with button in main module.
Because now in this MR in mobile we don't have navigation at all. - Status changed to Needs work
8 months ago 7:29am 22 April 2024 - Status changed to Needs review
8 months ago 6:03am 23 April 2024 - 🇬🇧United Kingdom catch
https://git.drupalcode.org/project/navigation/-/merge_requests/258#note_... is exactly what I meant. Could use review of the help text from someone who's more familiar with the functionality.
- 🇪🇸Spain ckrina Barcelona
@finnsky I've finally separate the Top Bar from the "Control Bar" because they will need to be different bars anyway. There is no way we will be able to fit the collapse button + the more actions + the save button... So they are 2 different things now.
- 🇪🇸Spain ckrina Barcelona
This has been directly merge in 80f2be3d on the MR to core issue ✨ Add the new Navigation to core as an Experimental module Fixed .
- Status changed to Fixed
8 months ago 11:23am 24 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.