Create feature flag module to control navigation top bar visibility

Created on 19 April 2024, 8 months ago
Updated 8 May 2024, 8 months ago

From @catch's comment in Add the new Navigation to core as an Experimental module Fixed Top Bar feature flag should be based in a feature flag module instead of config.

This might be a good idea, but it's not what I asked for in Add the new Navigation to core as an Experimental module Fixed , all I was suggesting was a feature flag module per Add an API for feature flags Active and 📌 Replace "Expose all fields as blocks to Layout Builder" configuration with feature flag Active - i.e. using the module being installed or not to determine whether the feature is enabled, instead of custom config. That way when the top bar becomes stable, navigation could remove the module enabled check and always have it on, then the feature flag module becomes obsolete and removed - instead of needing to update navigation module's configuration. If the top bar should never be enabled independently of the navigation module once everything is stable, then moving it into and out of a module might be too much extra work compared to just a feature flag module. Apologies if this wasn't clear on the other issue.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇪🇸Spain plopesc Valladolid

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @plopesc
  • Pipeline finished with Failed
    8 months ago
    #151123
  • Pipeline finished with Failed
    8 months ago
    Total: 227s
    #151125
  • Pipeline finished with Failed
    8 months ago
    Total: 259s
    #151130
  • Pipeline finished with Canceled
    8 months ago
    Total: 352s
    #151136
  • Pipeline finished with Success
    8 months ago
    Total: 229s
    #151140
  • 🇪🇸Spain plopesc Valladolid

    Backend part is ready for review. We need now to ensure that Top Bar specific styles are moved to the submodule.

  • 🇪🇸Spain ckrina Barcelona

    Working on the front-end for this.

    I wonder if the should call this module just "top_bar" instead of "navigation_top_bar".

  • Pipeline finished with Failed
    8 months ago
    Total: 219s
    #152655
  • Status changed to Needs review 8 months ago
  • 🇪🇸Spain ckrina Barcelona

    Ready for review.

  • 🇬🇧United Kingdom catch

    This might be a good idea, but it's not what I asked for in Add the new Navigation to core as an Experimental module Fixed , all I was suggesting was a feature flag module per Add an API for feature flags Active and 📌 Replace "Expose all fields as blocks to Layout Builder" configuration with feature flag Active - i.e. using the module being installed or not to determine whether the feature is enabled, instead of custom config. If the top bar should never be enabled independently of the navigation module once everything is stable, then moving it into and out of a module might be too much extra work compared to just a feature flag module. Apologies if this wasn't clear on the other issue.

  • 🇷🇸Serbia finnsky

    Probably here we also need to add checking if this topBar module not enabled then render some div with button in main module.
    Because now in this MR in mobile we don't have navigation at all.

  • Status changed to Needs work 8 months ago
  • Merge request !258#3442059 Replace config with feature flag module → (Merged) created by plopesc
  • Pipeline finished with Failed
    8 months ago
    Total: 230s
    #153952
  • Pipeline finished with Success
    8 months ago
    Total: 337s
    #153955
  • 🇪🇸Spain plopesc Valladolid
  • Status changed to Needs review 8 months ago
  • 🇪🇸Spain plopesc Valladolid

    Created new MR based on the suggestions from #6.

  • 🇬🇧United Kingdom catch

    https://git.drupalcode.org/project/navigation/-/merge_requests/258#note_... is exactly what I meant. Could use review of the help text from someone who's more familiar with the functionality.

  • 🇪🇸Spain ckrina Barcelona

    @finnsky I've finally separate the Top Bar from the "Control Bar" because they will need to be different bars anyway. There is no way we will be able to fit the collapse button + the more actions + the save button... So they are 2 different things now.

  • 🇪🇸Spain ckrina Barcelona

    ckrina changed the visibility of the branch 3442059-convert-top-bar-submodule to hidden.

  • Pipeline finished with Failed
    8 months ago
    Total: 272s
    #154231
  • Pipeline finished with Success
    8 months ago
    Total: 287s
    #154548
  • Pipeline finished with Success
    8 months ago
    Total: 231s
    #154656
  • Pipeline finished with Success
    8 months ago
    Total: 370s
    #154668
  • Pipeline finished with Success
    8 months ago
    Total: 221s
    #154773
  • 🇪🇸Spain ckrina Barcelona

    This has been directly merge in 80f2be3d on the MR to core issue Add the new Navigation to core as an Experimental module Fixed .

  • Pipeline finished with Skipped
    8 months ago
    #155288
  • Status changed to Fixed 8 months ago
  • 🇪🇸Spain ckrina Barcelona

    Merging to keep consistency on the contrib code.

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Skipped
    7 months ago
    #175270
  • Pipeline finished with Success
    7 months ago
    Total: 430s
    #179169
  • Pipeline finished with Success
    7 months ago
    Total: 692s
    #179190
  • Pipeline finished with Skipped
    5 months ago
    #221309
  • Pipeline finished with Skipped
    4 months ago
    #274716
  • Pipeline finished with Success
    about 2 months ago
    Total: 339s
    #331115
  • Pipeline finished with Success
    about 1 month ago
    Total: 219s
    #333261
  • Pipeline finished with Success
    about 1 month ago
    Total: 340s
    #333853
  • Pipeline finished with Failed
    about 1 month ago
    Total: 154s
    #333895
  • Pipeline finished with Failed
    about 1 month ago
    Total: 283s
    #333898
  • Pipeline finished with Success
    about 1 month ago
    Total: 300s
    #333899
  • Pipeline finished with Skipped
    about 1 month ago
    #334464
  • Pipeline finished with Success
    about 1 month ago
    Total: 155s
    #336153
  • Pipeline finished with Failed
    26 days ago
    Total: 78882s
    #349748
  • Pipeline finished with Canceled
    26 days ago
    Total: 642s
    #350976
  • Pipeline finished with Success
    24 days ago
    Total: 711s
    #352856
  • Pipeline finished with Success
    24 days ago
    Total: 706s
    #352870
  • Pipeline finished with Skipped
    19 days ago
    #356899
Production build 0.71.5 2024