- Issue created by @neclimdul
- Merge request !7856Issue #3444512: Pager current page announced twice β (Open) created by neclimdul
- Status changed to Needs review
7 months ago 6:59pm 30 April 2024 - πΊπΈUnited States neclimdul Houston, TX
These changes where just accidentally dropped from a re-roll. Patch to re-introduce them.
- Status changed to Needs work
7 months ago 7:59pm 30 April 2024 - πΊπΈUnited States smustgrave
Have a test failure so maybe fixing that will count as test coverage.
But will need a change record for contrib themes to update their templates.
- Status changed to Needs review
7 months ago 7:53pm 1 May 2024 - Status changed to RTBC
7 months ago 9:34pm 1 May 2024 - πΊπΈUnited States smustgrave
Thanks! As mentioned I feel the test change counts as coverage.
Change looks good.
- Status changed to Needs work
7 months ago 7:28am 2 May 2024 - π¬π§United Kingdom alexpott πͺπΊπ
π aria-current is giving an invalid value Fixed reverted the changes from β¨ Use aria-current=page in pagination links. Fixed so this issue might no longer true.
- Status changed to RTBC
7 months ago 7:30am 2 May 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Oh I see - iut just got the value wrong. This is still good.
- π¬π§United Kingdom alexpott πͺπΊπ
Re change record - it wasn't this change that necessitated the contrib / custom themes to change it was β¨ Use aria-current=page in pagination links. Fixed
Committed 3a54db4 and pushed to 11.x. Thanks!
Committed 93d5421 and pushed to 10.4.x. Thanks!
Committed 45cb9fe and pushed to 10.3.x. Thanks! -
alexpott β
committed 45cb9fed on 10.3.x
Issue #3444512 by neclimdul, alexpott, smustgrave: Pager current page...
-
alexpott β
committed 45cb9fed on 10.3.x
-
alexpott β
committed 93d54212 on 10.4.x
Issue #3444512 by neclimdul, alexpott, smustgrave: Pager current page...
-
alexpott β
committed 93d54212 on 10.4.x
- Status changed to Fixed
7 months ago 8:07am 2 May 2024 -
alexpott β
committed 3a54db4a on 11.x
Issue #3444512 by neclimdul, alexpott, smustgrave: Pager current page...
-
alexpott β
committed 3a54db4a on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.