aria-current is giving an invalid value

Looks like "page" was used in the original implementation but something changed between #93 ✨ Use aria-current=page in pagination links. Fixed and #96 ✨ Use aria-current=page in pagination links. Fixed that changed the value. Probably by accident?

Well yes, that's not right. Should be a true/false value https://www.w3.org/TR/wai-aria-1.2/#aria-current

Also related issue:
https://www.drupal.org/project/drupal/issues/3038523 📌 Add aria-current attribute to navigation items RTBC

I have added the aria-current="page", attached patch for same. Reference mozilla docs

The last submitted patch, 5: 3384679-5.patch, failed testing. View results →

Fixed the failed test. attached interdiff for same

Seems like a simple enough fix.

Pretty sure since it's an explicit value from the aria spec it should not be translated. That would lead to weird behaviors on translated sites.

Removed translation from aria attr, attach interdiff for same.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Fixed errors reported by bot

LGTM

Committed d6a990b and pushed to 11.x. Cherry-picked to 10.1.x as a non-disruptive bug fix. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.