Fix / Create schema definitions and appropriate tests for all (sub)modules

Created on 30 April 2024, 8 months ago
Updated 16 May 2024, 7 months ago

Problem/Motivation

We need to create a schema for the micon_link widget settings. Furthermore, we found out, that the schema tests in 🐛 Micon missing schema for its fields definitions Needs review don't suffice and that the schema is still broken for the main module's widget definition.

Meaning, we need to also adjust those.

Steps to reproduce

Proposed resolution

Fix the stated problems.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

🇩🇪Germany Grevil

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Grevil
  • Assigned to Anybody
  • 🇩🇪Germany Grevil

    Alright, these are quite a big chunk of changes, but this will ensure the module's formatter / widget settings schema to be valid at all times.

    Please review! I still need to test the update hooks, but they should work. We updated formatter settings similar in photoswipe before.

    Happy reviewing!

  • Status changed to Needs review 8 months ago
  • Issue was unassigned.
  • Status changed to Needs work 8 months ago
  • 🇩🇪Germany Grevil

    All update hooks work as expected!

    Interestingly enough, I found a bug in config inspector. The config inspector still shows schema errors for the icon widget "packages" setting, even after resaving the widget settings / creating a new field and adjusting the widget settings. This doesn't make sense as

    1. The new tests do NOT throw schema errors anymore after the new schema update.
    2. We are using the EXACT SAME "packages" setting for a widget in our "micon_link" submodule with the EXACT SAME schema, but there we do not get any schema errors from config inspector
    3. The same checkboxes form element + schema combination is used in the "book" core module. See here and here.

    I think it might have something to do with the name of the formatter.

  • Status changed to Needs review 8 months ago
  • 🇩🇪Germany Grevil

    Ok, that is fascinating. It really is the name! If we change the name of the widget, all schema errors are gone!

    I think this is related to the fact, that the widget has the same id as the field_type AND the formatter. And somehow Drupal core's schema validation works as intended, but the config inspector UI doesn't.

    I'll create a follow-up issue for that and a config_inspector bug report.

  • Assigned to Grevil
  • Status changed to Needs work 8 months ago
  • 🇩🇪Germany Anybody Porta Westfalica

    Whao lots of important bug fixes. Hope it all goes well ;)

    Just left once textual comment. RTBC afterwards.

    • Grevil committed 9e5407a0 on 2.x
      Issue #3444371: Fix / Create schema definitions and appropriate tests...
  • Issue was unassigned.
  • Status changed to RTBC 8 months ago
  • Status changed to Fixed 8 months ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024