- Issue created by @Anybody
- First commit to issue fork.
- 🇩🇪Germany Grevil
Interestingly enough, config inspector AND the tests both won't show any schema errors... interesting.
- 🇩🇪Germany Grevil
No idea, the schema definition seems to be fine on micon's site.
I tried redefining the storage definition using:
field.storage_settings.micon_string: type: mapping label: 'Micon string settings' mapping: max_length: type: integer label: 'Maximum length' case_sensitive: type: boolean label: 'Case sensitive' is_ascii: type: boolean label: 'Contains US ASCII characters only'
and "extending" it:
field.storage_settings.micon_string: type: field.storage_settings.string
similiar to https://git.drupalcode.org/project/entity_reference_revisions/-/blame/8....
Nothing seems to work and neither the tests nor the config inspector throws any schema errors before or after the changes.
- 🇩🇪Germany Anybody Porta Westfalica
@Grevil: Did you set up such a field like the one that shows the error in the tests?
My guess is, that this will first happen with a field set up?
- Status changed to Needs review
9 months ago 1:17pm 19 March 2024 - Status changed to Needs work
9 months ago 1:27pm 19 March 2024 - 🇩🇪Germany Anybody Porta Westfalica
@Grevil: Nice! I left two minor comments.
But we shouldn't tag a release too soon with this change, I think. We need to be sure this has no side-effects.Also one hard part is left I guess: Removing the old config from existing installations?
Perhaps you can find a snippet for that? - Issue was unassigned.
- Status changed to Needs review
9 months ago 9:10am 21 March 2024 - 🇩🇪Germany Grevil
Alright all done! Added an update hook as well, and it runs well and as expected:
After the update, the field still works as expected and displays the given icon. Furthermore, no default_value is overriden or any other important field storage values.
- 🇩🇪Germany Anybody Porta Westfalica
Thanks @Grevil! LGTM! Still it's a heavy, but important change, so I'd like to have a sign-off by another maintaner who tested this.
RTBC from my side.
We should then wait with a new tagged release, once signed off and merged into dev, to see if this causes trouble somewhere.
Thank you! - Assigned to jacobbell84
- Issue was unassigned.
- Status changed to Needs work
9 months ago 12:00pm 27 March 2024 - 🇩🇪Germany Grevil
@Anybody found another schema error:
content.field_symbol.settings.packages Undefined
- Assigned to jacobbell84
- Status changed to Needs review
9 months ago 12:35pm 27 March 2024 - Status changed to RTBC
8 months ago 9:43am 30 April 2024 - 🇩🇪Germany Grevil
I guess, @jacobbell84 is quite busy. I just ran into this issue again. As you RTBC'd this, I am just going to merge it. It was tested enough in my opinion.
- Issue was unassigned.
- Status changed to Fixed
8 months ago 9:49am 30 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.