[8.4] Fix implicitly nullable type declarations in core/tests

Order of arguments needs fixes

Line   core/tests/Drupal/Tests/Core/Entity/Routing/DefaultHtmlRouteProviderTest.php  
 ------ ------------------------------------------------------------------------------ 
  64     Deprecated in PHP 8.1: Required parameter $entity_type follows                
         optional parameter $expected.                                                 
  102    Deprecated in PHP 8.1: Required parameter $entity_type follows                
         optional parameter $expected.                                                 
  203    Deprecated in PHP 8.1: Required parameter $entity_type follows                
         optional parameter $expected.                                                 
  263    Deprecated in PHP 8.1: Required parameter $entity_type follows                
         optional parameter $expected.     

For the test failure, didn't check to see if the docs needed to be updated as well.

I did revert docs changes, they should go in follow-up as the patch automated with script

it should wait for 2 tests that are moved to 📌 [8.4] Fix implicitly nullable type declarations for phpstan job Needs review

Using ~/.config/composer/vendor/bin/php-cs-fixer fix --config .php-cs-fixer.dist.php -vvv

# .php-cs-fixer.dist.php

$finder = \PhpCsFixer\Finder::create()
#    ->in(__DIR__)
    ->in("core/tests")
    ->name('*.engine')
    ->name('*.module')
    ->name('*.profile')
    ->name('*.theme')
    ->name('*.inc')
    ->name('*.php');

$config = new \PhpCsFixer\Config();

return $config->setRules([
        'nullable_type_declaration_for_default_null_value' => true,
    ])
    ->setFinder($finder);

If I understand this is blocked on 📌 [8.4] Fix implicitly nullable type declarations for phpstan job Needs review also from the slack thread https://drupal.slack.com/archives/C04CHUX484T/p1714420723894339 we should try and get the docs right? Hopefully as Longwave mentioned are inherited so should be a single change.

Yes, idea is to fix places which require manual intervention in 📌 [8.4] Fix implicitly nullable type declarations for phpstan job Needs review

The rest should be done using fixer to get reproducible results

Discussed to not split fixes https://drupal.slack.com/archives/C04CHUX484T/p1715262829267749

andypost → closed merge request !7813