- Issue created by @andypost
- Merge request !7813[8.4] Fix implicitly nullable type declarations in core/tests #3444023 → (Closed) created by andypost
- Status changed to Needs review
4 months ago 3:17am 29 April 2024 - 🇫🇷France andypost
Order of arguments needs fixes
Line core/tests/Drupal/Tests/Core/Entity/Routing/DefaultHtmlRouteProviderTest.php ------ ------------------------------------------------------------------------------ 64 Deprecated in PHP 8.1: Required parameter $entity_type follows optional parameter $expected. 102 Deprecated in PHP 8.1: Required parameter $entity_type follows optional parameter $expected. 203 Deprecated in PHP 8.1: Required parameter $entity_type follows optional parameter $expected. 263 Deprecated in PHP 8.1: Required parameter $entity_type follows optional parameter $expected.
- Status changed to Needs work
4 months ago 1:02pm 29 April 2024 - 🇺🇸United States smustgrave
For the test failure, didn't check to see if the docs needed to be updated as well.
- Status changed to Needs review
4 months ago 3:30am 30 April 2024 - 🇫🇷France andypost
I did revert docs changes, they should go in follow-up as the patch automated with script
it should wait for 2 tests that are moved to 📌 [8.4] Fix implicitly nullable type declarations for phpstan job Needs review
Using
~/.config/composer/vendor/bin/php-cs-fixer fix --config .php-cs-fixer.dist.php -vvv
# .php-cs-fixer.dist.php $finder = \PhpCsFixer\Finder::create() # ->in(__DIR__) ->in("core/tests") ->name('*.engine') ->name('*.module') ->name('*.profile') ->name('*.theme') ->name('*.inc') ->name('*.php'); $config = new \PhpCsFixer\Config(); return $config->setRules([ 'nullable_type_declaration_for_default_null_value' => true, ]) ->setFinder($finder);
- Status changed to Postponed
4 months ago 4:29pm 7 May 2024 - 🇺🇸United States smustgrave
If I understand this is blocked on 📌 [8.4] Fix implicitly nullable type declarations for phpstan job Needs review also from the slack thread https://drupal.slack.com/archives/C04CHUX484T/p1714420723894339 we should try and get the docs right? Hopefully as Longwave mentioned are inherited so should be a single change.
- 🇫🇷France andypost
Yes, idea is to fix places which require manual intervention in 📌 [8.4] Fix implicitly nullable type declarations for phpstan job Needs review
The rest should be done using fixer to get reproducible results
- Status changed to Closed: won't fix
4 months ago 2:31pm 9 May 2024 - 🇫🇷France andypost
Discussed to not split fixes https://drupal.slack.com/archives/C04CHUX484T/p1715262829267749