- Issue created by @quietone
- Status changed to Needs review
4 months ago 4:15am 27 April 2024 - 🇳🇿New Zealand quietone New Zealand
The first commit added the sniffs and forced errors to provide evidence of the errors the sniffs will find. The results are at https://git.drupalcode.org/project/drupal/-/jobs/1446421
- Status changed to RTBC
4 months ago 5:13pm 27 April 2024 - First commit to issue fork.
- 🇬🇧United Kingdom longwave UK
Aren't these already included by
<rule ref="Drupal.Commenting.FunctionComment">? - Status changed to Postponed: needs info
4 months ago 3:32am 28 April 2024 - 🇦🇺Australia mstrelan
Agree with #10. Maybe we can test this with a PR that we would expect to fail and see if it's detected. In other words, needs steps to reproduce, marking PMNMI.
- Status changed to Needs review
4 months ago 1:11am 30 April 2024 - 🇳🇿New Zealand quietone New Zealand
#10 and #11. I think this is answered in comment #3. Or are you asking for something else as proof?
- 🇦🇺Australia mstrelan
@quietone we're saying that the first commit should already fail without any changes to phpcs.xml.dist, or at least we believe it should. My understanding is that
<rule ref="Drupal.Commenting.FunctionComment">on line 68 should already include all the ones you've added, minus the ones that are excluded on line 69-74. - Status changed to Closed: works as designed
4 months ago 8:42am 3 May 2024 - 🇳🇿New Zealand quietone New Zealand
@mstrelan, thanks.
Well, the thing is I would swear that I made such a test as the first thing I did and the errors were not picked up. I thought it was off but continued on. I just retested with the files here and without the changes to phpcs.xml and, of course, the errors are found. Clearly, what I did and what I thought I did were two different things.
Sorry for the noise.