- Issue created by @m4olivei
- ๐จ๐ฆCanada m4olivei Grimsby, ON
I fired up an MR thinking this would be easy. I spent a good half hour just finding where that border is defined that is obstructing the tooltip. It's here, for future me or others that come to this issue ๐
https://git.drupalcode.org/project/drupal/blob/11.x/core/modules/navigat...
I am with @dalin at DrupalCon Portland 2024, and I am going to look at fixing this issue within the next hour.
- ๐จ๐ฆCanada dalin Guelph, ๐จ๐ฆ, ๐
I'm mentoring @aronm on how to contribute to their first d.o issue.
- Status changed to Needs review
4 months ago 11:03pm 8 May 2024 Problem:
The tooltip itself has a z-index of 801. The .admin-toolbar::after element which is part of admin-toolbar, has a z-index of 501. The #menu-footer has a z-index of -1, which is overriding the 801 z-index of the tooltip.
Changing the z-index of #menu-footer to a higher value caused the element to overlap .admin-toolbar and make the border disappear.
Tried applying a border-inline-end to the #menu-footer, which caused a flicker when the menu expanded.
The arrangement of all the associated elements needs be refactored to fix this correctly. However, a simpler fix is to change the hardcoded offset position of the tooltip in tooltip.js. Shifted the offset from 6px to 18 px.
Thanks @javi-er for assistance with this issue.
- ๐ท๐ธSerbia finnsky
Thank you for you work here!
In my point of view we still need to fix z-index and we cannot move tooltip.
I see 2 ways:
1. Manage border on menu level.
2. Backport popover api approach from https://www.drupal.org/project/drupal/issues/3197758 โจ Create a new component: Toggletip RTBC it will be on top layer
https://developer.chrome.com/blog/introducing-popover-apiIn any case i don't think it is novice issue anymore.
- Status changed to Needs work
4 months ago 8:29am 9 May 2024 - ๐ฎ๐ณIndia Gauravvv Delhi, India
Gauravvvv โ made their first commit to this issueโs fork.
- Status changed to Needs review
4 months ago 1:50pm 9 May 2024 - Status changed to RTBC
4 months ago 2:02pm 9 May 2024 - ๐ช๐ธSpain ckrina Barcelona
ckrina โ changed the visibility of the branch 11.x to hidden.
-
ckrina โ
committed 4839441f on 11.x
Issue #3443835 by Gauravvvv, aronm, m4olivei, finnsky, dalin, javi-er: '...
-
ckrina โ
committed 4839441f on 11.x
-
ckrina โ
committed 43c771b3 on 11.0.x
Issue #3443835 by Gauravvvv, aronm, m4olivei, finnsky, dalin, javi-er: '...
-
ckrina โ
committed 43c771b3 on 11.0.x
-
ckrina โ
committed 1142c1c4 on 10.4.x
Issue #3443835 by Gauravvvv, aronm, m4olivei, finnsky, dalin, javi-er: '...
-
ckrina โ
committed 1142c1c4 on 10.4.x
-
ckrina โ
committed 981989f1 on 10.3.x
Issue #3443835 by Gauravvvv, aronm, m4olivei, finnsky, dalin, javi-er: '...
-
ckrina โ
committed 981989f1 on 10.3.x
- Status changed to Fixed
4 months ago 3:54pm 9 May 2024 We considered the implemented approach but the problem with this is that when the menu slides to the right it covers the borders for a short amount of time causing some flickering, that's why the original approach used an
:after
pseudoelement imo.
It's a tiny issue and not very noticeable, so I'll leave to the maintainer to decide if further action is needed, see attached video.Automatically closed - issue fixed for 2 weeks with no activity.