- Issue created by @sukr_s
- 🇺🇸United States smustgrave
Thanks for opening, tagging for new users as should be a good intro for them.
- First commit to issue fork.
- Assigned to nexusnovaz
- Merge request !7947Issue #3443748: Added assert to check if status code is 200 → (Open) created by nexusnovaz
- Issue was unassigned.
- Status changed to Needs review
7 months ago 7:48pm 7 May 2024 - 🇬🇧United Kingdom nexusnovaz
This is ready for review. I have added the code which i believe to be correct, though, im unable to test locally (unsure how, even after googling, using ddev)
- Status changed to Needs work
7 months ago 8:00pm 7 May 2024 - 🇺🇸United States smustgrave
Believe the permissions have to be slightly updated as the test is failing
https://git.drupalcode.org/issue/drupal-3443748/-/jobs/1536596
- 🇺🇸United States xjm
This does seem like a good issue for novice contributors to investigate (with regard to why the test is currently failing). One helpful step would also be to manually test a site with the test's setup and validate that it is actually working correctly.
Additionally, I left a note on the MR to remove the old inline comment.
- Status changed to Needs review
7 months ago 4:18pm 10 May 2024 - 🇬🇧United Kingdom nexusnovaz
Hi, i believe this is now good for review. Added the permission to allow it to pass the test and now we're all green.
Apologies for the commit spam, im unsure how to test locally and am still fairly new to Drupal.
Hopefully this solution is fine!
- Status changed to RTBC
7 months ago 7:39pm 10 May 2024 - 🇺🇸United States smustgrave
No need to apologize! Good job figuring out the permission. Do believe this one is good.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 565a9f1401 to 11.x and 4874e83fb3 to 11.0.x and 9181970ca4 to 10.4.x and 0f4d8306b1 to 10.3.x. Thanks!
-
alexpott →
committed 0f4d8306 on 10.3.x
Issue #3443748 by NexusNovaz, smustgrave: Testcase creates false...
-
alexpott →
committed 0f4d8306 on 10.3.x
-
alexpott →
committed 9181970c on 10.4.x
Issue #3443748 by NexusNovaz, smustgrave: Testcase creates false...
-
alexpott →
committed 9181970c on 10.4.x
-
alexpott →
committed 4874e83f on 11.0.x
Issue #3443748 by NexusNovaz, smustgrave: Testcase creates false...
-
alexpott →
committed 4874e83f on 11.0.x
- Status changed to Fixed
6 months ago 6:48am 12 May 2024 -
alexpott →
committed 565a9f14 on 11.x
Issue #3443748 by NexusNovaz, smustgrave: Testcase creates false...
-
alexpott →
committed 565a9f14 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.