Fix phpcs issues

Mohd Sahzad → made their first commit to this issue’s fork.

Tis is looking good, but

Maybe we use different PHPCS settings so I still get warnings:

FILE: /var/www/html/web/modules/contrib/webform_analysis/src/Form/WebformAnalysisForm.php
-----------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------
122 | ERROR | [x] Use null coalesce operator instead of ternary operator.
-----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------

FILE: /var/www/html/web/modules/contrib/webform_analysis/src/WebformAnalysisInterface.php
-----------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
-----------------------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
138 | ERROR | [x] Data types in @return tags need to be fully namespaced
154 | ERROR | [x] Data types in @return tags need to be fully namespaced
-----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------

FILE: /var/www/html/web/modules/contrib/webform_analysis/src/WebformAnalysis.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
55 | ERROR | [x] list(...) is forbidden, use [...] instead.
161 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Hi

I applied MR !8 and tested the PHPCS and I confirmed that it fixes the PHPCS issues

➜  webform_analysis git:(b254416) curl https://git.drupalcode.org/project/webform_analysis/-/merge_requests/8.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6078    0  6078    0     0  11687      0 --:--:-- --:--:-- --:--:-- 11801
patching file 'modules/webform_node_analysis/src/EntityTypeInfo.php'
patching file 'modules/webform_node_analysis/src/Plugin/Derivative/WebformNodeAnalysisLocalTask.php'
patching file 'src/Form/WebformAnalysisForm.php'
patching file 'src/Plugin/Block/WebformAnalysisBlock.php'
patching file 'src/WebformAnalysis.php'
patching file 'src/WebformAnalysisInterface.php'
➜  webform_analysis git:(b254416) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml webform_analysis 
➜  contrib git:(master) ✗ 

(y)

Automatically closed - issue fixed for 2 weeks with no activity.