Enable Drupal.NamingConventions.ValidVariableName.LowerCamelName

For the goal of getting the rule in this looks good. Didn't see any variable name changes, Don't even want to think of the effort it will be update those.

Don't even want to think of the effort it will be update those.

Falls into the category of not worth it.

Can an MR be opened against 10.3.x ... i didn't cherry pick because maybe one of the removed modules more cause PHPCS to fail.

Committed 25de611 and pushed to 11.x. Thanks!

Reroll for 10.3.x seems good.

PHPStan fails when trying to commit this locally

  412    Ignored error pattern #^Variable \$validate_types might not be                                        
         defined\.$# in path                                                                                   
         /home/dave/projects/core-commits/core/modules/views/src/Plugin/views/argument/ArgumentPluginBase.php  
         is expected to occur 1 time, but occurred 2 times.                                                    
  413    Variable $validate_types might not be defined.      

I rebased MR !7899 on 10.4.x and was not able to reproduce the PHPStan error in #12. And tests are passing. The diff also applies to 10.3.x and it passed commit-code-checks locally.

So, let's try again.

Rebase looks fine for 10.3.x

Committed and pushed c27ea21712 to 10.4.x and 6bca41b201 to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

quietone → closed merge request !7766

quietone → closed merge request !7899