- Issue created by @rajveergangwar
- Assigned to praveen rani
- Issue was unassigned.
- Status changed to Needs work
7 months ago 3:38am 29 April 2024 - 🇦🇺Australia VladimirAus Brisbane, Australia
Thank you for submitting the issue.
Updating metadata.As issue was stale for a few days, I will be removing assigned person.
Once you are ready to commit, feel free to assign yourself.
Thanks again! 🧁 - Assigned to Gurkawal
Hi @VladimirAus , I've identified this issue within the module where paragraphs could be deleted without any confirmation, which can lead to accidental data loss. I've implemented and propose a solution for it that asks for confirmation before proceeding with deletion and provides a cancel button that redirects back to the paragraphs listing page. I have created MR to resolve. Please review it.
- Status changed to Needs review
7 months ago 5:40am 30 April 2024 - 🇮🇳India divya.sejekan
The Patch gets successfull applied , the delete confirmation is added now.
Testing steps :
1. Add the paragraph and paragraph admin module\
2. Add a paragraph type
3. Add a paragraph
4. /admin/content/paragraphs
5. Delete the paragraph 'verified with MR - 8.x-1.x in D10.2
RTBC ++
Keeping in review for further reviews
- 🇮🇳India riddhi.addweb
I've applied the patch and everything seems good to me. Now, when I attempt to delete a paragraph, a confirmation popup appears.
- Status changed to RTBC
7 months ago 6:40am 30 April 2024 - Issue was unassigned.
- Status changed to Needs work
7 months ago 3:11pm 4 May 2024 - 🇦🇺Australia VladimirAus Brisbane, Australia
@Gurkawal: if you identified security issue, you should submit it here → .
If you are referring to 🐛 CSRF on delete url Fixed , it was fixed.The following issues needs to be fixed:
Drupal\Core\Entity\EntityDeleteForm
should be be used.- PHPCS warnings
- Tests needs to be modified / added
- First commit to issue fork.
- Status changed to Needs review
6 months ago 11:10am 7 May 2024 - 🇮🇳India manish-31
I have pushed the required changes in Merge Request !8 suggested by @VladimirAus
MR updates -
- Removed the controller since we are now using entity delete form we no longer need the controller to delete paragraphs.
- Used
Drupal\Core\Entity\ContentEntityDeleteForm
to build the delete form with confirmation. - Added new assertions to test the delete functionality as per the new changes.
- I have verified there are no PHPCS warnings now.
Needs review. Thanks!
- Status changed to RTBC
4 months ago 1:23pm 4 July 2024 - gaurav gupta Jaipur, Rajasthsan
Hello
i have tested and checked the MR8 and it is working fine
Thanks - 🇦🇺Australia VladimirAus Brisbane, Australia
VladimirAus → changed the visibility of the branch 3443579-paragraph-delete-should to hidden.
- Status changed to Fixed
4 months ago 12:10am 7 July 2024 -
VladimirAus →
committed 0218fabe on 8.x-1.x authored by
Gurkawal →
Issue #3443579 by Gurkawal, manish-31, divya.sejekan, riddhi.addweb,...
-
VladimirAus →
committed 0218fabe on 8.x-1.x authored by
Gurkawal →
Automatically closed - issue fixed for 2 weeks with no activity.