Incompatible with diff module

I think that the relevant change is the addition of the route subscriber in https://git.drupalcode.org/project/wse/-/commit/69838e13489891a9995fe8f8...

We can do something like this in WSE, but we also need an issue in the Diff module to factor out getting the revision IDs from \Drupal\diff\Form\RevisionOverviewForm::buildForm() into a separate method, because overriding and copying all that code is a bit too much to do in this module.

Once we have that issue (and patch), we need to extend this patch and override \Drupal\diff\Form\RevisionOverviewForm.

Ran into this exact issue on a client site today. Did the diff module issue get opened?

@heddn, no.. I was hoping someone else could do it and I would finish up the bits needed here.

✨ Allow usage of revision comparison inside workspaces Needs work seems like a close issue to this. Going to hijack it. Changes pushed over there.

✨ Allow usage of revision comparison inside workspaces Needs work is green if we can get it to RTBC.

It's RTBC now :)

adamzimmermann → closed merge request !81

Should this issue be for version 2.0.x-dev? I think that is why the MR I opened had a diff wildly different than what I expected.

Going to try take two on generating a new patch that adds return types to the methods to make them match the method signatures in the latest diff module.

This takes the work from the patch in comment #3 and adds return types to fix a WSOD issue and removes some debugging code I found in the patch. I'm able to load the diff route now with this module enabled.

FWIW I based my patch branch off of the 2.0.x branch and the patch in #3 applied cleanly as my starting point for updating it.

Upstream issue has merged. No tagged release yet.

Implemented the additional changes detailed in #3.

This is now working nicely with the latest dev version of the Diff module, so I've committed the patch above to 2.0.x and cherry-picked to 1.0.x. Thanks everyone!

Automatically closed - issue fixed for 2 weeks with no activity.