- Issue created by @catch
- First commit to issue fork.
- Merge request !7679[#3442864] fix(css): Update misc/components icon paths after moving files β (Open) created by dww
- Status changed to Needs review
5 months ago 7:14pm 23 April 2024 - πΊπΈUnited States dww
I know this is tagged novice, which I am not π, but @catch pinged in #bugsmash about this since it's time sensitive. So I pushed fixes (I think) and opened an MR. My local can't run 11.x right now, but I'll see if this applies to 10.3.x and try to test it there.
- πΊπΈUnited States dww
Adding STR. I tried testing locally and at first failed since Claro doesn't have the bug. You have to turn off Claro to see it in action.
- π¬π§United Kingdom catch
Yes I also noticed this testing with stark (with the ajax test module enabled on that controller, trying to debug something else).
- πΊπΈUnited States dww
Do we need tests for this? I put that as the remaining task in the summary.
- π¬π§United Kingdom catch
For me this fits into π± [policy, no patch] Better scoping for bug fix test coverage RTBC - i.e. I think we should open an issue to add test coverage. The throbber is afaik untestable in that it's by definition only visible during loading so js tests can't reliably find it. Maybe tablesort would be more straightforwardly testable? But then how do we assert CSS images are reference correctly in a test, especially without hardcoding the new path? Feels like something for CSS regression testing which we don't have.
- πΊπΈUnited States dww
- Status changed to RTBC
5 months ago 7:57pm 23 April 2024 - πΊπΈUnited States smustgrave
When the ticket is so well filled out makes it so much easier so thank you!
Oddly enough I had a local setup already using stark when I opened this ticket.
Following the steps to reproduce I can confirm seeing what @catch mentioned.Paths appear to be correctly updated and glad we could push test coverage, seems like one of those that could take a while.
- Status changed to Fixed
5 months ago 12:43am 24 April 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed 348a8c27c6 to 11.x and d385e87ecd to 10.3.x. Thanks!
-
alexpott β
committed d385e87e on 10.3.x
Issue #3442864 by dww, catch: [regression] 404 for misc/throbber-active....
-
alexpott β
committed d385e87e on 10.3.x
-
alexpott β
committed 348a8c27 on 11.x
Issue #3442864 by dww, catch: [regression] 404 for misc/throbber-active....
-
alexpott β
committed 348a8c27 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.