[regression] 404 for misc/throbber-active.gif / misc/loading-small.giff

I know this is tagged novice, which I am not 😂, but @catch pinged in #bugsmash about this since it's time sensitive. So I pushed fixes (I think) and opened an MR. My local can't run 11.x right now, but I'll see if this applies to 10.3.x and try to test it there.

Adding STR. I tried testing locally and at first failed since Claro doesn't have the bug. You have to turn off Claro to see it in action.

Yes I also noticed this testing with stark (with the ajax test module enabled on that controller, trying to debug something else).

Do we need tests for this? I put that as the remaining task in the summary.

For me this fits into 🌱 [policy, no patch] Better scoping for bug fix test coverage RTBC - i.e. I think we should open an issue to add test coverage. The throbber is afaik untestable in that it's by definition only visible during loading so js tests can't reliably find it. Maybe tablesort would be more straightforwardly testable? But then how do we assert CSS images are reference correctly in a test, especially without hardcoding the new path? Feels like something for CSS regression testing which we don't have.

📌 Add test coverage for 404 on throbber-active.gif and friends Active

When the ticket is so well filled out makes it so much easier so thank you!

Oddly enough I had a local setup already using stark when I opened this ticket.
Following the steps to reproduce I can confirm seeing what @catch mentioned.

Paths appear to be correctly updated and glad we could push test coverage, seems like one of those that could take a while.

Committed and pushed 348a8c27c6 to 11.x and d385e87ecd to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.