AJAX error when password field is hidden

The patch from 2779485 🐛 Ajax breaks password reset Postponed: needs info works to hide the error at least, but still leaves AJAX in place. I think 2779485 started off as a different issue however since comment 5 and 6 perhaps they are experiencing this issue.

We came across this issue too.

I suggest another approach to avoid this error.

Since the password field is hidden, the password constraints table should not be render at all.

So I suggest the following change

$password_mutable = $form['account']['pass']['#access'] ?? TRUE;
  // Load form if relevant and password is mutable.
  if (\Drupal::service('password_policy.validation_manager')->tableShouldBeVisible() && $password_mutable) {

The patch from MR !87 for local test.

Th CI error is caused by 🐛 Ignore the new user.logout.confirm route in the PasswordPolicyEventSubscriber RTBC .

ankitv18 → changed the visibility of the branch 3442714-ajax-error-when to hidden.

We have the same symptom, but a slightly different cause and therefore MR87 does not work for us.
In our case, we have a custom form mode and $form['account']['pass'] is not set at all. Therefore, the check falsely identifies the password as being mutable.

$password_mutable = $form['account']['pass']['#access'] ?? TRUE;

I would suggest the check could be changed to the following, where we check if the pass field is even present and if so check the access to that. I would also reverse the order of the and as it is less expensive that way.

  $password_mutable = (isset($form['account']['pass']) && ($form['account']['pass']['#access'] ?? TRUE));

  // Load form if relevant.
  if ($password_mutable && \Drupal::service('password_policy.validation_manager')->tableShouldBeVisible()) {

The check also needs to be added to check if validation should run (otherwise we just don't show the table rows, but validation will still catch us). That possibly should be though in the PasswordPolicyValidationManager.

if ($password_mutable && \Drupal::service('password_policy.validation_manager')->validationShouldRun()) {
    $form['#validate'][] = '_password_policy_user_profile_form_validate';
    $form['#after_build'][] = '_password_policy_user_profile_form_after_build';
  }