- Issue created by @alexpott
- 🇺🇸United States phenaproxima Massachusetts
Why is this core MVP?
Deduplication isn't really necessary, as far as I know; the result of these methods is used to check if they contain a specific value; we don't really care (yet) how many times they appear. So while I don't necessarily object to using array_unique(), I'm not sure this actually needs to be core MVP.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Yeah I agree this is not mvp for me too. I made it mvp because core committer noted this. But as long as we have the issue I think we're fine.
- First commit to issue fork.
- Merge request !123Issue #3442017: \Drupal\Core\Recipe\RecipeConfigurator::listAllExtensions and... → (Closed) created by vasike
- Status changed to Needs review
2 months ago 7:51pm 23 April 2024 - 🇷🇴Romania vasike Ramnicu Valcea
not mvp, but good to have .. before some "unique" use cases come around.
- Status changed to Needs work
2 months ago 8:31am 24 April 2024 - Status changed to Needs review
2 months ago 9:54am 24 April 2024 - 🇷🇴Romania vasike Ramnicu Valcea
there is no sorting ... it's just bad PHP naming flag ...
SORT_XXXinstead of an explicitARRAY_ITEMS_COMPARISON_TYPE_XXXflag constant name - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 3d55e7cd72f to 11.x and 456a05d8dee to 10.3.x. Thanks!
-
alexpott →
committed 456a05d8 on 10.3.x
Issue #3442017 by vasike, alexpott, larowlan: \Drupal\Core\Recipe\...
-
alexpott →
committed 456a05d8 on 10.3.x
- Status changed to Fixed
2 months ago 10:50am 24 April 2024 -
alexpott →
committed 3d55e7cd on 11.x
Issue #3442017 by vasike, alexpott, larowlan: \Drupal\Core\Recipe\...
-
alexpott →
committed 3d55e7cd on 11.x
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Cherry-picked to ✨ Add recipes api as experimental API to core Needs review too.
- 67abbceb committed on patch
Update recipe 10.3.x patch 456a05d8 Issue #3442017 by vasike, alexpott,...
- 67abbceb committed on patch
- 4919bacc committed on patch
Update recipe 11.x patch 3d55e7cd Issue #3442017 by vasike, alexpott,...
- 4919bacc committed on patch
Automatically closed - issue fixed for 2 weeks with no activity.
