Odd behaviour on multi lingual sites during replace in certain circumstances

Looking at this some more, it's perhaps odd in the end result but logically it's correct, based on the current code. When we loop through the languages we search once again for the original string, which in this example it still exists and thus replaces it again. I'll need to try and pick my way through the multi lingual aspect of this.

          foreach ($other_languages as $langcode => $languageName) {
            if ($node->hasTranslation($langcode)) {
              $node = $node->getTranslation($langcode);
              $nodeField = $node->get($fieldname);
            }
            $fieldValue = $nodeField->getValue()[0];
            // Replace the search term with the replace term.
            $fieldValue['value'] = preg_replace($conditionVals['phpRegex'], $values['replace'], $fieldValue['value']);
            $node->$fieldname = $fieldValue;
          }

Run 1 - English

My string

Updated to My string - updated

Run 2 - Welsh

My string - updated (My string obviously still there)

Updated to My string - updated - updated

This very much sounds similar to 🐛 Paths incorrectly replaced Active - maybe that one should be closed as duplicate as it's less documented.

As this is an effect, which can have unexpected and wide results, I think we should mark it major. What's your suggestion to fix this @aaron.ferris? Would you prepare a MR maybe?

Apologies for not responding @anybody, I haven't had a chance to look at this properly yet. Ill hopefully get some time over the holidays.

Hi to all!

@smustgrave
I have made a patch that (I think and I hope) to solve the problem.

The problem I have seen is that when a site has several languages, the replacement is done as many times as languages the site has.

Example:
Searched word: “WORD_TO_TEST”
Replace with: “WORD_TO_TO_TEST1”
Result: “WORD_TO_TO_TEST11111111”

With this patch, result is “WORD_TO_TEST1”.

I have tested in a site with 27 languages and in a site with only the default language.

An auxiliary function is included in the patch to avoid code duplication. The patch applies only to the Drupal plugin. I would be checking this behavior for Paragraph plugins as well, but I don't have much time.

B.R.

Sorry, I resubmit a second version of the patch for version 2.0.0-beta1, since the previous version of the patch was not in the 2.0.0-beta1 branch.