- Issue created by @Grevil
- First commit to issue fork.
- Status changed to Needs work
7 months ago 1:49pm 30 April 2024 - 🇩🇪Germany Grevil
@LRWebks and I talked about this internally, and came to the conclusion, that we should talk about the module's default behavior.
We currently have the global setting "watchdog_mailer_enable" and "enable" per notification object:
In our opinion, "watchdog_mailer_enable" should have their default set to "true". It won't send any mails anyway, since we do not have any notification objects at the start anyway. ⇾ A status message letting the user know, he needs to define notification objects to use the module definitely make sense.
"Default" notification objects do not make any sense in this context, so this isn't an option. - Status changed to Needs review
7 months ago 1:14pm 13 May 2024 - Status changed to Needs work
7 months ago 1:21pm 13 May 2024 - 🇩🇪Germany Grevil
Added a few comments, which need to get resolved. I haven't reviewed the Form yet, since it will change quite a bit through the ajax implementation.
- 🇩🇪Germany lrwebks Porta Westfalica
As of now we have decided to implement the AJAX calls for additional notification objects in a follow-up issue, so you can check the Form now.
- Status changed to Needs review
6 months ago 8:52am 27 May 2024 - 🇩🇪Germany lrwebks Porta Westfalica
That about wraps up everything that is supposed to be done in this issue, I feel like the module is in a great condition now! :)
Please review!
The AJAX integration will be handled in a follow-up issue as that will be another bit of work and as of now this MR is functional so we can merge this right away before continuing with AJAX.
Once everything is done here, and it is RTBC, we can also set all the child issues to fixed so that everyone who worked on there can get their fair share of credit! - Assigned to lrwebks
- 🇩🇪Germany Grevil
Code LGTM!
Could you finally reinstall the module and do some manual testing of all the new features (additionally some human error testing, e.g. blanks set incorrectly, defined mails incorrectly, sepereated with "." instead of "," etc.?
- Status changed to Needs work
6 months ago 12:47pm 28 May 2024 - Status changed to Needs review
6 months ago 1:40pm 28 May 2024 - Issue was unassigned.
- Status changed to RTBC
6 months ago 3:00pm 28 May 2024 - 🇩🇪Germany Grevil
Alright, great stuff! @LRWebks just confirmed internally, that the update hook also works as expected! :)
Let's create a first alpha release! Great work, thank you! 🎉
- Merge request !18Issue #3441753 by LRWebks: [Meta] 3.x Feature / Concept Improvement issue → (Merged) created by Grevil
- Status changed to Fixed
6 months ago 3:05pm 28 May 2024 - 🇩🇪Germany Grevil
Reversed first merge, as the MR still targeted the wrong branch.
Automatically closed - issue fixed for 2 weeks with no activity.