- Issue created by @pdureau
- First commit to issue fork.
- 🇫🇷France just_like_good_vibes PARIS
Hello,
here is a quite deep modification of the sub-module ui_patterns_field_formatter,
in order to tackle several issues, and stabilize.
A lot of code has been removed, according to the current or related issues, and also some simplifications has been introduced.There are less generated ui patterns source plugins (at least we get rid of the "by bundle"),
context has been greatly improved to allow field formatters to work inside view fields and more.Some new helper functions in field formatter classes have helped the retrieval of settings and context values.
- Merge request !84Issue #3440319 + #3440278 + #3440202 + #3440310 → (Merged) created by just_like_good_vibes
- Status changed to Needs review
7 months ago 11:28pm 12 April 2024 - Assigned to pdureau
- 🇫🇷France just_like_good_vibes PARIS
More code was added to entirely cope with questions from issue #13440310 📌 [2.0.0-alpha2] Formatters: technical feedbacks from alpha1 Needs review
- 🇫🇷France pdureau Paris
"For each" & "For all" field formatters
✅ ComponentEachFormatter is not present when the field has a single value cardinality
However, let's discuss and clairfy what we want to achieve here:
- Are we sure the 2 formatters have the same sources?
- Are we also working at the field property level with ComponentAllFormatter?
- ...
Simpler and shorter source naming
✅ The naming is now "Field property Width", "Field property Height"...
It would be better with ":" between the deriver and the property label: "Field property: Width", "Field property: Height"... I will do the commit.
“Formatted value” source for slots is missing
✅ it is present and is named "Field Formatter".
However:
- Let's test if it is recursive once 📌 [2.0.0-alpha3] Form builder: Simpler sources selector (2/2) + make it nestable Needs work is done (because of the Form ID)
- It would be better as "Field formatter", sentence case. I will do the commit.
The context is not applied in Views
Tested with a node's title field:
- For each: ❌ the form doesn't load
- For all: ✅ We see only field properties now. According to Mikael, it is a generic "universal" system instead of just covering views' context.
- 🇫🇷France musa.thomas France 🇫🇷
Musa.thomas → made their first commit to this issue’s fork.
- 🇫🇷France just_like_good_vibes PARIS
Hello again, just to summarize what happened in the last hours.
Thomas → added some refactoring today, and i just added a few more commit on top of that during the two last hours in order to simplify a little and correct a few remaining bugs.The current state is not totally perfect but worth it compared to the past.
This MR should at least cover all the comments referenced by this issue and the three other issues mentioned in the related issues sections. Many thanks Pierre → for your precious reviews and comments. -
pdureau →
committed 28cf60dd on 2.0.x authored by
just_like_good_vibes →
Issue #3440319, #3440278, #3440202, #3440310 by just_like_good_vibes,...
-
pdureau →
committed 28cf60dd on 2.0.x authored by
just_like_good_vibes →
- Issue was unassigned.
- Status changed to Fixed
7 months ago 3:20pm 16 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.