- Issue created by @pdureau
- Assigned to pdureau
- Status changed to Needs work
7 months ago 8:57pm 15 April 2024 - 🇫🇷France pdureau Paris
$wrapper_id = 'ui-patterns-prop-item-' . $prop_id; > ADD random if many form
Started.
- 🇫🇷France pdureau Paris
Make sure the slots' source selector works with Layout Builder, it has a broken look with ui_suite_bootstrap. Maybe the simplification will help.
- 🇫🇷France Grimreaper France 🇫🇷
modules/ui_patterns_field_formatters/src/Plugin/UiPatterns/Source/FieldFormatterFormBase.php also needs
$wrapper_id = Html::getUniqueId('field-formatter-settings-ajax');
While comparing the HTML of a native field_multiple_value_form on a content type. The "remove" button is in the third "td" while In UI Patterns it is in the second. So maybe there is some malformed HTML too.
Also I am not sure if field_multiple_value_form is appropriate to use outside of the field API. Maybe there are field API related mechanism that ensures it works properly but are missing in the configuration forms.
- 🇫🇷France Grimreaper France 🇫🇷
When using a component without props, I get the warning:
Warning: Trying to access array offset on null in Drupal\ui_patterns\Element\ComponentPropsForm::buildForm() (line 62 of modules/custom/ui_patterns/src/Element/ComponentPropsForm.php).
- 🇫🇷France pdureau Paris
Other idea: https://www.drupal.org/project/multivalue_form_element →
However:
- no Delete button and it looks complicated to add: ✨ Add a delete button Active
- this form element expects the first line to be already initialized. This first line will be duplicated every time we click on “Add” button. However, us, we start with an empty form, with no source in the slot
- 🇫🇷France pdureau Paris
This task is strategic because following tasks depend on it:
- "Formatter" source (from ui_patterns_field_formatters) and by the upcoming ✨ [2.0.0-alpha3] Add block source (for slots) Fixed need the forms to be nestable (with working random non-duplicated wrapper IDs)
- ✨ [2.0.0-alpha3] Make Form Builder and/or Source plugins forms extendable Active
- ✨ [2.0.0-alpha3] Add allow_variant_expose source plugin Active
- 🇫🇷France pdureau Paris
Once done, restest FieldFormatter source from ui_pattterns_field_formatters.
- First commit to issue fork.
- Merge request !104Issue #3427538 allow to nest components :) → (Merged) created by just_like_good_vibes
- Status changed to Needs review
6 months ago 2:52pm 2 June 2024 - 🇫🇷France just_like_good_vibes PARIS
Hello,
i have worked on this issue, focusing on how to nest patterns.
the new code also removes the key "component_form" from the form objects...
please review, thank you :) - 🇫🇷France pdureau Paris
Follow up: 🐛 [2.0.0-alpha3] Form builder: Simpler & nestable sources selector (3/3) Active
- Status changed to RTBC
6 months ago 10:15am 3 June 2024 -
pdureau →
committed e56f768f on 2.0.x authored by
just_like_good_vibes →
Issue #3427538 by just_like_good_vibes: Form builder: Simpler...
-
pdureau →
committed e56f768f on 2.0.x authored by
just_like_good_vibes →
- Issue was unassigned.
- Status changed to Fixed
6 months ago 10:16am 3 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.