[1.0.14] AesirX-Analytics

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,>DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the branch to review and the project name.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications, even to leave a comment similar to the following one. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• It is also preferable to wait before using a CLI tool → to report what needs to be changed, especially because the comment left from Code Review Administrators suggests to use PHP_CodeSniffer. Before that, manual reviews should be done.
• Reviewers should not copy-paste the output of a CLI tool. They should use a CLI tool only once per application. When they do that, they should later verify the code has been correctly changed; this means, for example, that adding a documentation comment that is not correct just to avoid to get a warning/error is not a correct change that should be reported in a further comment.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

mainis wrong names for branch. Release branch names always end with the literal .x as described in Release branches → .

After updating as per comment #2 change status to Needs Review

Projects hosted on drupal.org are licensed under GPLv2+, the same license used from Drupal core. If you are licensing a project under a different license, it cannot he hosted on drupal.org. More details are given in Drupal Git Contributor Agreement & Repository Usage Policy → .

All code that is a derivative work of Drupal (typically PHP code, including but not limited to: core patches, modules, themes, etc) committed to Drupal.org's git repository is licensed as GPL version 2.0 and later (official short identifier: “GPL-2.0-or-later”). This means that the code is licensed under GPLv2, and there exists an option that allows downstream recipients to re-license the code to be under a later version of GPL.

For code licensed under GPLv3, see See I want to release my work under GPL version 3 or under GPL version 2-only. Can I do so and host it on Drupal.org? →

No. You can release your work under any GPL version 2 or later compatible license. However, you may only check it into Drupal's Git repositories if you are releasing it under the same license as Drupal itself, that is GPL version 2 or later, allowing users to choose between the terms of the GPL version 2 or the terms in any new versions as updated by the FSF. If you are unable or unwilling to do so, do not check it into a Drupal Git repository.

I did the required change

The license has not been yet changed.

@apaderno

I would expect the bigger concern with this application should be that, ignoring the auto-generated assets/ folder and the build/yarn.lock file the code in the main branch is, on a cursory glance, a duplicate of. https://www.drupal.org/project/aesirx_analytics →
(note the difference is an underscore).

Cursory review is that mostly the majority of changes would be PHPCS.

Factor in the comment from #3436454: [1.0.13] AesirX Analytics → :

...the user who did initial setup and development of the code no longer works for our company.

This looks like an attempt to use a separate application with squashed commit. I will additionally note none of the aesirx_analytics commits mention the current applicant.

While I tend to believe the current application process is broken and should not be used for controlling if a module can opt-into security coverage (leading to situations like this) I do believe the records on this one warrant further review bay Code Review Administrators before the applicant or the community proceed further.

@apaderno I did the change only in the verison branch and not in main. Just did that change.

@cmlara reported a relevant concern.

I concern I can not fix.

I can not pull the person who did the first application back into the company to follow through. In the other application it was said that the person has to make the majority of commits so the only real option was to start from zero. I didn't hide that we had made an attempt to submit this in the past.

We are in a deadlock:
* I can't continue the first application
* I can't start a new one because the first exists.

I think that is something you guys have to discuss and find a way out. I did my best to make you all happy.

Notice that we just require a project hosted on drupal.org where the commits are mostly (but preferably, all) done by the person who applies. As long as the project is not copied from another project, all is fine. It does not even need to be the project you would want to opt into security advisory policy.

So, from our side, we have a way out.

So what is the concern?

So what is convern? What do you want from me to do?

So what is the concern? What do you want me to do?

Create a project that can be used for these applications, or change the link given to the issue summary to point to an existing project you created.

I am changing priority as per Issue priorities → .

This thread has been idle, in the Needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).

If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.