- Issue created by @musa.thomas
- Status changed to Postponed: needs info
10 months ago 5:57pm 11 April 2024 - 🇫🇷France pdureau Paris
Thomas, let's discuss about this issue. I don't understand what needs or be re-enable here.
We expect 3 sources in this scope:
- The one from field label to string prop >> Already implemented
- The one from formatted field (with another field formatter) to slot >> TODO
- The deriver, from each field property to compatible props >> Already implemented
Pierre want it as new settings inside the form...
We need to avoid sources specific to field types, so I don't see which settings I am wanting here :)
Once the source from formatted field (with another field formatter) to slot will be implemented, it can be used with entity reference fields, for example with the "Rendered entity" field formatter.
- 🇫🇷France musa.thomas France 🇫🇷
It'as about what you call "transverse entity" when the field is an entity reference. What we did first is to set field of entity reference directly inside source and you said to us you want it as an new select inside settings.
Maybe we can have new source plugin called "field of entity reference" something like this and have two select to get the field and property of entity reference. - Status changed to Postponed
9 months ago 3:25pm 16 April 2024 - Assigned to just_like_good_vibes
- 🇫🇷France just_like_good_vibes PARIS
let's do a little revival but differently with our new architecture of DerivableContexts.
i take the issue
- 🇫🇷France just_like_good_vibes PARIS
i think the code may be ready. I just included temporarily some code from 🐛 [2.0.0-beta3] Unable to properly use derivable contexts in a views row style options Active
- 🇫🇷France just_like_good_vibes PARIS
and finally, a nice working version to review :DDD
- 🇩🇪Germany Christian.wiedemann
Hi @just_like_good_vibes,
it works great. I tested it right now. Works great - but it is hard to review.
We should split into:
- The refactoring of the context filter system.
- The refactoring of views.
- The entity referenceWhat do you think?
- 🇫🇷France just_like_good_vibes PARIS
hello,
as i said, the refactoring of views was just copy pasted from another issue :)
i just pushed it here in this temporary MR to be able to fully test the functionality and have some reviews from you :) - 🇫🇷France pdureau Paris
Hi guys,
Thanks for working on this feature.
However, can we wait I have created a companion issue before merging ? Maybe we will find some links between both
- 🇫🇷France just_like_good_vibes PARIS
blocked by 📌 [2.0.0-beta4] Evolution of DeriableContexts : refactor code with source plugin manager, add several contexts in derivation, and better support prop types Active which is in review
- 🇫🇷France just_like_good_vibes PARIS
ok now that other issues have been created and merged, let the magic of entity reference happens !
i will repush the code, let's go ! - Merge request !238Resolve #3440293 : Source plugins for entity reference fields → (Merged) created by just_like_good_vibes
- 🇫🇷France just_like_good_vibes PARIS
I have reworked the code, even better than last time.
please review :) -
just_like_good_vibes →
committed 58bb95db on 2.0.x
Issue #3440293 by just_like_good_vibes, christian.wiedemann: Source...
-
just_like_good_vibes →
committed 58bb95db on 2.0.x
Automatically closed - issue fixed for 2 weeks with no activity.