Fix issues reported by PHPCS

fixed the issue reported by phpcs please review the attached patch.

Hi

I applied patch #3 and I confirmed that it fixes all the PHPCS issues

➜  domain_access_logo git:(2.0.x) curl https://www.drupal.org/files/issues/2024-04-12/phpcs-3440266-3.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2537  100  2537    0     0   4795      0 --:--:-- --:--:-- --:--:--  4964
patching file domain_access_logo.module
patching file 'src/Form/DomainAccessLogoSettingsForm.php'
➜  domain_access_logo git:(2.0.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml domain_access_logo 
➜  contrib git:(master) ✗ 

Hey, thanks for the work you've done. Drupal is moving away from the use of patches and expects to work with Merge Requests to contribute to core/modules/themes/...

And this issue just arose or was discovered from using Gitlab CI.

So try to use a Merge Request next time as it doesn't take much more time to contribute. The guide can be found https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →

And I ask you to read https://www.drupal.org/about/core/blog/drupalci-and-all-patch-testing-wi... → to have more understanding why the transition is being done.

1. +++ b/src/Form/DomainAccessLogoSettingsForm.php
   @@ -67,10 +67,10 @@ class DomainAccessLogoSettingsForm extends ConfigFormBase {
   -      $container->get('config.factory'),
   -      $container->get('cache_tags.invalidator'),
   -      $container->get('entity_type.manager')
   -    );
   +          $container->get('config.factory'),
   +          $container->get('cache_tags.invalidator'),
   +          $container->get('entity_type.manager')
   +      );
   

   Incorrect indents

2. +++ b/src/Form/DomainAccessLogoSettingsForm.php
   @@ -110,9 +110,11 @@ class DomainAccessLogoSettingsForm extends ConfigFormBase {
   -            '#description' => $this->t('The logo for this domain/subdomain.<br>Allowed types: @extensions.', [
   -              '@extensions' => $extensions,
   -            ]),
   +            '#description' => $this->t(
   +                'The logo for this domain/subdomain.<br>Allowed types: @extensions.', [
   +                  '@extensions' => $extensions,
   +                ]
   +            ),
   

   Incorrect indents

@atul_ghate your path introduced more PHPCS

@clarkssquared if you want to review patches, make sure the review is correct as I can not trust any of them anymore because I see by the eye there are more CS issues. Don't just blindly follow a tool next time to do reviews.

Therefor I created an issue fork with the code changes that are correct.

Please let me know you follow up your issue and have understood the above.

Hi @tim-diels, thank you for sharing this information and for the guidance on using Merge Requests for contributions. I'll make sure to follow the guidelines provided and transition to using Merge Requests in future contributions. I apologize for the PHPCS issues in my patch and will address them in future contributions.

Automatically closed - issue fixed for 2 weeks with no activity.