- Issue created by @nevahen
- Merge request !7421Issue #3439946: Fix optimize_js variable assignment in AjaxResponseAttachmentsProcessor class → (Open) created by nevahen
- Status changed to Needs review
11 months ago 5:43pm 10 April 2024 - Status changed to Needs work
11 months ago 2:40pm 11 April 2024 - 🇺🇸United States smustgrave
Thank you for reporting but can you provide steps to reproduce?
This may also require test to show the problem.
This is something I noticed while I was debugging something else.
A small piece of the diff From this issue https://www.drupal.org/project/drupal/issues/3373328 🐛 ^10.1 CSS aggregation breaks during maintenance mode Fixed shows possible typo / missing ! on the $optimize_js part
- $optimize_css = !defined('MAINTENANCE_MODE') && $this->config->get('css.preprocess'); - $optimize_js = !defined('MAINTENANCE_MODE') && $this->config->get('js.preprocess'); + $optimize_css = !$maintenance_mode && $this->config->get('css.preprocess'); + $optimize_js = $maintenance_mode && $this->config->get('js.preprocess');I guess one could check cache keys during ajax request, as the AssetResolver won't generate "1" as last character due the current implementation - I'll check later if I can do some simple steps if they are needed.