Account created on 10 April 2024, 5 months ago
#

Merge Requests

Recent comments

This is something I noticed while I was debugging something else.

A small piece of the diff From this issue https://www.drupal.org/project/drupal/issues/3373328 🐛 ^10.1 CSS aggregation breaks during maintenance mode Fixed shows possible typo / missing ! on the $optimize_js part

-    $optimize_css = !defined('MAINTENANCE_MODE') && $this->config->get('css.preprocess');
-    $optimize_js = !defined('MAINTENANCE_MODE') && $this->config->get('js.preprocess');
+    $optimize_css = !$maintenance_mode && $this->config->get('css.preprocess');
+    $optimize_js = $maintenance_mode && $this->config->get('js.preprocess');

I guess one could check cache keys during ajax request, as the AssetResolver won't generate "1" as last character due the current implementation - I'll check later if I can do some simple steps if they are needed.

Production build 0.71.5 2024