Fix Node tests that rely on UID1's super user behavior - Blocks

Created on 10 April 2024, 3 months ago
Updated 12 July 2024, about 24 hours ago

Problem/Motivation

In ๐Ÿ“Œ Add a container parameter that can remove the special behavior of UID#1 Fixed an approach was taken where we can simply flag tests that are failing if we turn off user 1's super user powers, so that they can be taken care of in a followup. This issue is to collect all of these followups.

The goal is to have no tests in Drupal core that rely on UID1's special privileges so that we:

  1. Know these tests are correctly assigning the necessary permissions to run
  2. Can turn off the super user access policy in D11, knowing it won't break core
  3. Can remove the super user access policy in D12, providing an admin account recovery tool to replace it

Steps to reproduce

Go into any of the tests flagged with:

  /**
   * {@inheritdoc}
   *
   * @todo Remove and fix test to not rely on super user.
   * @see https://www.drupal.org/project/drupal/issues/3437620
   */

And:

  1. Remove the code below that sets the usesSuperUserAccessPolicy to TRUE.
  2. Run the test to see which test methods are failing

Proposed resolution

Assign the right permissions to make the test go green without the super user access policy. Those few tests that specifically test said policy can obviously stay, but will be removed along with the policy in D12.

Remaining tasks

  • core/modules/node/tests/src/
    • Functional/NodeAccessCacheabilityTest.php
    • Functional/NodeAccessGrantsCacheContextTest.php
    • Kernel/NodeAccessLanguageAwareCombinationTest.php
    • Kernel/NodeAccessLanguageAwareTest.php
    • Kernel/NodeAccessLanguageTest.php
    • Kernel/Views/NodeViewsFieldAccessTest.php
๐Ÿ“Œ Task
Status

Needs review

Version

11.0 ๐Ÿ”ฅ

Component
Node systemย  โ†’

Last updated about 23 hours ago

No maintainer
Created by

๐Ÿ‡ฌ๐Ÿ‡ทGreece vensires

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.69.0 2024