Homebox is quite complex due to the many levels of permissions and especially cloning of the presets to instances.
To ensure nothing really bad can happen finally, we should implement a safety-net in
In these, I'd say we should implement Exception-driven permission checks, for example:
This might not be perfect architecture, but should be seen as "last resource ass-saver" ;) ;D (sorry) if all other hurdles should break.
Background: I'm afraid of edge-cases where a user might get passed a wrong (preset or other user) instance.
Can we have simple (programmatic?) tests to ensure these exceptions work as expected eventually?
Postponed
3.0
Code
Thinking about this once again, I don't think this is necessary. The "retrieveInstance" Method, through which we load all of our homeboxes is quite bulletproof. Furthermore, we implement our own HomeboxAccessHandler and have all critical access checks validated through appropriate tests.
I'll keep this open for now, but I am not 100% sold on this yet.