- Issue created by @yogesh.k
- 🇬🇧United Kingdom aaron.ferris
You could do something like the attached, its not add/remove one like the OP so haven't raised a MR but it's one possible approach to make this configurable.
- First commit to issue fork.
- Assigned to sourabhsisodia_
- Merge request !2unearth-3438801: Added the feature to add more than 5 slides. → (Open) created by sourabhsisodia_
- Issue was unassigned.
- Status changed to Needs review
7 months ago 12:06pm 12 April 2024 Resolved the bug to add more than 5 slides and added remove button to remove a particular slide.
While creating a merge request was getting an error saying - "unable to merge due to missing pipeline ". So also added pipeline.
- 🇮🇳India divya.sejekan
Tested using patch '3428801-configurable-slider-count.patch'
User is able to add slides , after incrementing the slider count we have to save then add the slide details .. its not dynamic
Keeping this in reviewThe MR is giving error
@divya.sejekan Solved the error , and remove slide function is asynchronous and i think we don't need to make the add slide functionality asynchronous , because it will require to change many correlated things to it
- Status changed to Needs work
4 months ago 9:25am 12 July 2024 - 🇮🇳India Tirupati_Singh
Hi @sourabhsisodia_, I tried applying the MR as a patch but the patch not applied successfully. I've reviewed the changes by checking out to the issue branch i.e.,
3438801-
, the issue of not being able to add more than 5 sliders has been resolved but the images for slide is now not getting saved for slides. After increasing thenumber of slider images
field value the slider item fields is being updated after reloading the page.
Also there's no conditional checking for the slider item field value. If no content is provided in theSlider Title, Slider Description, Slider Button Text
fields then empty dom structure for slider is being rendered. I've attached attachments for reference. Hence moving issue status to Needs work. - Status changed to Needs review
4 months ago 3:35pm 12 July 2024 - Status changed to Needs work
4 months ago 5:50am 17 July 2024 - 🇮🇳India Tirupati_Singh
@sourabhsisodia_ , I've reviewed the MR!2 and added comment for the same. Please check. Getting website encountered an error after the latest changes has been done. Attaching the screenshot for your reference. Hence, moving the issue status to Needs work.