Not able to add more than 5 silde

Created on 5 April 2024, 7 months ago
Updated 17 July 2024, 4 months ago

Problem/Motivation

In the slider should have an add/remove button for each slide and user can add more than 5 slide.

Steps to reproduce

  • Install theme using composer
  • Go to the appearance setting /admin/appearance/settings/unearth
  • Edit the Slider images section
🐛 Bug report
Status

Needs work

Version

1.0

Component

Code

Created by

🇮🇳India yogesh.k

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @yogesh.k
  • 🇬🇧United Kingdom aaron.ferris

    You could do something like the attached, its not add/remove one like the OP so haven't raised a MR but it's one possible approach to make this configurable.

  • First commit to issue fork.
  • Assigned to sourabhsisodia_
  • Issue was unassigned.
  • Status changed to Needs review 7 months ago
  • Resolved the bug to add more than 5 slides and added remove button to remove a particular slide.

  • Pipeline finished with Success
    7 months ago
    Total: 243s
    #144862
  • Pipeline finished with Success
    7 months ago
    Total: 273s
    #145150
  • While creating a merge request was getting an error saying - "unable to merge due to missing pipeline ". So also added pipeline.

  • 🇮🇳India divya.sejekan

    Tested using patch '3428801-configurable-slider-count.patch'
    User is able to add slides , after incrementing the slider count we have to save then add the slide details .. its not dynamic
    Keeping this in review

    The MR is giving error

  • Pipeline finished with Success
    7 months ago
    Total: 213s
    #149794
  • @divya.sejekan Solved the error , and remove slide function is asynchronous and i think we don't need to make the add slide functionality asynchronous , because it will require to change many correlated things to it

  • Updated the MR according to review .

  • Pipeline finished with Success
    6 months ago
    Total: 213s
    #189729
  • Status changed to Needs work 4 months ago
  • 🇮🇳India Tirupati_Singh

    Hi @sourabhsisodia_, I tried applying the MR as a patch but the patch not applied successfully. I've reviewed the changes by checking out to the issue branch i.e., 3438801-, the issue of not being able to add more than 5 sliders has been resolved but the images for slide is now not getting saved for slides. After increasing the number of slider images field value the slider item fields is being updated after reloading the page.
    Also there's no conditional checking for the slider item field value. If no content is provided in the Slider Title, Slider Description, Slider Button Text fields then empty dom structure for slider is being rendered. I've attached attachments for reference. Hence moving issue status to Needs work.

  • Pipeline finished with Success
    4 months ago
    Total: 166s
    #222829
  • Status changed to Needs review 4 months ago
  • Status changed to Needs work 4 months ago
  • 🇮🇳India Tirupati_Singh

    @sourabhsisodia_ , I've reviewed the MR!2 and added comment for the same. Please check. Getting website encountered an error after the latest changes has been done. Attaching the screenshot for your reference. Hence, moving the issue status to Needs work.

Production build 0.71.5 2024