- Issue created by @Freddy Rodriguez
- Assigned to abhishek_virasat
- Issue was unassigned.
- Status changed to Needs review
8 months ago 5:02am 4 April 2024 - 🇮🇳India sarwan_verma
Hi@Freddy Rodriguez,
I have fixed this issue "TypeError: explode(): Argument #2 ($string) must be of type string, null given in explode() (line 101 of modules/contrib/o365/src/RolesService.php)" and also attached patch ,
kindly review and verify. - Status changed to Needs work
8 months ago 5:05am 4 April 2024 - 🇳🇱Netherlands fabianderijk Alphen aan den Rijn
Hi @sarwan_verma can you create a merge request for this patch?
- First commit to issue fork.
- Status changed to Needs review
8 months ago 5:43am 4 April 2024 -
fabianderijk →
committed ce928757 on 5.0.x authored by
immaculatexavier →
Issue #3438025: TypeError: explode(): Argument #2 ($string) must be of...
-
fabianderijk →
committed ce928757 on 5.0.x authored by
immaculatexavier →
- Status changed to Fixed
8 months ago 5:53am 4 April 2024 - 🇳🇱Netherlands fabianderijk Alphen aan den Rijn
Thanks for the MR. This is now merged. A new release will be created in a few hours
- 🇦🇩Andorra fgarciap
Hi,
We have applied this patch and this error it's the same but now in line 106. Did we make anything wrong? When are you going to upload new realease?
-
fabianderijk →
committed 5e9ebb33 on 5.0.x
Issue #3438025 by fabianderijk, immaculatexavier: TypeError: explode():...
-
fabianderijk →
committed 5e9ebb33 on 5.0.x
- 🇳🇱Netherlands fabianderijk Alphen aan den Rijn
@fgarciap i've just updated the dev version of the module. Could you check this version? I can't reproduce this error anymore.
- 🇦🇩Andorra fgarciap
amazing, now works without errors!!!
Big Thanks.
Only one additional question (just curiosity). If we want require login in all pages we have to check your settings module or install one module like 'require login' or similar?
- 🇳🇱Netherlands fabianderijk Alphen aan den Rijn
Great, I'll create the release ASAP.
About the always login. The o365 module won't fix that for you. The module can redirect your users to Microsoft if you want without interference of the Drupal login form, but it won't handle the permissions as you would like.
- 🇳🇱Netherlands fabianderijk Alphen aan den Rijn
The 5.0.7 release had been created and should be available in a few minutes
Automatically closed - issue fixed for 2 weeks with no activity.