- Issue created by @leslieg
- First commit to issue fork.
- Status changed to Needs review
8 months ago 11:46am 10 April 2024 - 🇩🇪Germany marcoliver Neuss, NRW, Germany
FYC, here's an MR.
"Clear/recommended filters" buttons had no type attribute set, making them submit buttons by default. So they'd implicitly be "clicked" whenever the form was submitted, toggling the default filters.
- 🇮🇪Ireland lostcarpark
Needs a rebase and Svelte rebuild to fix the merge conflict.
There are some ESLint and PHPStan errors, but they don't appear to be related to this change.
I will try to rebase today, then happy to mark RTBC.
- 🇮🇪Ireland lostcarpark
I have rebased, but I noticed the compiled Svelte before wasn't minimized. After my recompile, it's minimized. Checking if there's an update to the compile procedure I've missed.
- 🇺🇸United States bernardm28 Tennessee
Tested this with DrupalPod 10.1.x, stable theme. Seems to work as expected.
Searching and hitting enter multiple times does not remove any of the search filters.
I also tested this by removing one of the default test filters. Removing the maintained filter and searching repeatedly works as expected. - Status changed to RTBC
8 months ago 5:38pm 25 April 2024 - First commit to issue fork.
-
chrisfromredfin →
committed 143c8ce3 on 1.0.x authored by
marcoliver →
Resolve #3437721 "Searching for modules"
-
chrisfromredfin →
committed 143c8ce3 on 1.0.x authored by
marcoliver →
- Status changed to Fixed
8 months ago 3:36pm 1 May 2024 - 🇺🇸United States chrisfromredfin Portland, Maine
Good find, and good quick fix!
Automatically closed - issue fixed for 2 weeks with no activity.