Searching for modules sometimes removes filters

Created on 2 April 2024, 3 months ago
Updated 15 May 2024, about 1 month ago

Problem/Motivation

"Search for modules" on the Browse toggles between displaying the selected filters and not displaying the selected filters each time you hit "enter" to view the results of the search. The filters selected should always be displayed.

Steps to reproduce

Spin up a site with the Project Browser module enabled. (Try it Now link on drupal.org/project/project_browser)
Log in
Select Browse from the Extend menu item in the Admin menu
Leave the default filter selected, enter a search term and hit enter. The filters will be displayed
Hit enter again and the filters are not displayed.
Hit enter a few times to understand the behavior.

Proposed resolution

Fix the behavior on the page to always display the selected filters when hitting Enter to search.

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States leslieg

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @leslieg
  • First commit to issue fork.
  • Merge request !454Resolve #3437721 "Searching for modules" → (Merged) created by marcoliver
  • Pipeline finished with Success
    3 months ago
    Total: 343s
    #142717
  • Pipeline finished with Failed
    3 months ago
    Total: 372s
    #142718
  • Status changed to Needs review 3 months ago
  • 🇩🇪Germany marcoliver Neuss, NRW, Germany

    FYC, here's an MR.

    "Clear/recommended filters" buttons had no type attribute set, making them submit buttons by default. So they'd implicitly be "clicked" whenever the form was submitted, toggling the default filters.

  • Pipeline finished with Failed
    3 months ago
    Total: 354s
    #142760
  • 🇮🇪Ireland lostcarpark

    Needs a rebase and Svelte rebuild to fix the merge conflict.

    There are some ESLint and PHPStan errors, but they don't appear to be related to this change.

    I will try to rebase today, then happy to mark RTBC.

  • Pipeline finished with Failed
    2 months ago
    Total: 481s
    #148636
  • Pipeline finished with Failed
    2 months ago
    Total: 1934s
    #148639
  • 🇮🇪Ireland lostcarpark

    I have rebased, but I noticed the compiled Svelte before wasn't minimized. After my recompile, it's minimized. Checking if there's an update to the compile procedure I've missed.

  • 🇮🇳India divya.sejekan

    Not able to apply the patch .. error in patch

  • Pipeline finished with Failed
    2 months ago
    Total: 530s
    #148968
  • Pipeline finished with Failed
    2 months ago
    Total: 371s
    #148982
  • 🇺🇸United States bernardm28 Tennessee

    Tested this with DrupalPod 10.1.x, stable theme. Seems to work as expected.
    Searching and hitting enter multiple times does not remove any of the search filters.
    I also tested this by removing one of the default test filters. Removing the maintained filter and searching repeatedly works as expected.

  • Status changed to RTBC 2 months ago
  • 🇺🇸United States bernardm28 Tennessee
  • Pipeline finished with Failed
    2 months ago
    Total: 469s
    #156707
  • Pipeline finished with Skipped
    about 2 months ago
    #161680
  • First commit to issue fork.
  • Pipeline finished with Skipped
    about 2 months ago
    #161686
  • Status changed to Fixed about 2 months ago
  • 🇺🇸United States chrisfromredfin Portland, Maine

    Good find, and good quick fix!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024