Contrib.social

Add validation constraints to system.diff

Open on Drupal.org →
Created on 2 April 2024, 5 months ago
Updated 16 April 2024, 5 months ago

Problem/Motivation

system.diff has 2 property path that are not yet validatable:

./vendor/bin/drush config:inspect --filter-keys=system.diff --detail --list-constraints
➜  🤖 Analyzing…

 Legend for Data: 
  ✅❓  → Correct primitive type, detailed validation impossible.
  ✅✅  → Correct primitive type, passed all validation constraints.
 ---------------------------------------- --------- ------------- ------ ------------------------------------------ 
  Key                                      Status    Validatable   Data   Validation constraints                    
 ---------------------------------------- --------- ------------- ------ ------------------------------------------ 
  system.diff                              Correct   67%           ✅❓   ValidKeys: '<infer>'                      
   system.diff:                            Correct   Validatable   ✅✅   ValidKeys: '<infer>'                      
   system.diff:_core                       Correct   Validatable   ✅✅   ValidKeys:                                
                                                                            - default_config_hash                   
   system.diff:_core.default_config_hash   Correct   Validatable   ✅✅   NotNull: {  }                             
                                                                          Regex: '/^[a-zA-Z0-9\-_]+$/'              
                                                                          Length: 43                                
                                                                          ↣ PrimitiveType: {  }                     
   system.diff:context                     Correct   Validatable   ✅✅   ValidKeys: '<infer>'                      
   system.diff:context.lines_leading       Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here  
   system.diff:context.lines_trailing      Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here  
 ---------------------------------------- --------- ------------- ------ ------------------------------------------

Steps to reproduce

  1. Get a local git clone of Drupal core 10.3.x.
  2. composer require drupal/config_inspector — or manually install https://www.drupal.org/project/config_inspector/releases/2.1.5 → or newer (which supports Drupal 11!)
  3. composer require drush/drush
  4. vendor/bin/drush config:inspect --filter-keys=system.diff --detail --list-constraints

Proposed resolution

Add validation constraints to:

  1. system.diff:context.lines_leading
  2. system.diff:context.lines_trailing

For examples, search *.schema.yml files for the string constraints: 😊

Reach out to @borisson_ or @wimleers in the #distributions-and-recipes.

Remaining tasks

User interface changes

None.

API changes

Data model changes

More validation 🚀

Release notes snippet

None.

📌 Task
Status

Fixed

Version

10.3 ✨

Component
System  →

Last updated 1 day ago

No maintainer
Created by

🇮🇳India narendraR Jaipur, India

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024