- Issue created by @mschudders
- Status changed to Needs review
11 months ago 1:36pm 2 April 2024 - 🇮🇳India sarwan_verma
Hi @Mschudders,
I have fixed this issue "Drupal 10 compatibility" and also attached patch,
please review and verify. - 🇧🇪Belgium andreasderijcke Antwerpen / Gent
@sarwan_verma Why do you create a patch while there is already a MR present?
Also your patch claims Drupal 11 compatibility for this module, which is not the subjet of this issue and obviously was not tested, as #3438029 is a result of incompatibility with the updated dependencies. There might be even more, so let us stick to making sure D10 compatibility is fully covered.
Because #3438029 will arise if you use the proposed MR and needs more testing on its own, I've marked it as a child issue of this one.
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
This is not needed just for drupal 10, but it is for monolog 3 module?
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Actually, looking at this again it looks like we shouldn't really need to have drupal/core as a dependency, let's figure that out in a new issue.
This one no longer applies, but it looks like we need it in our project as well. Back to needs work.
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Created 📌 Investigate if we need to have drupal/core as an explicit dependency Active as a followup
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Locally this works now. I would like it if someone else could verify this.
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Manually tested this in the office with @ghuygens. This works. I'm going to commit this.
-
borisson_ →
committed ae652579 on 1.x authored by
mschudders →
Issue #3436686 by borisson_, mschudders, andreasderijcke, ghuygens:...
-
borisson_ →
committed ae652579 on 1.x authored by
mschudders →
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Credit from 🐛 Compatibility with 'Itspire - Monolog Loki' ^2.0 Needs work